From: Michael Snyder <msnyder@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, jimb@redhat.com
Subject: Re: symtab.c change breaks assembly lang debugging
Date: Wed, 07 Nov 2001 07:59:00 -0000 [thread overview]
Message-ID: <3BF58D22.6CA0AFF9@cygnus.com> (raw)
In-Reply-To: <20011116152941.A15960@nevyn.them.org>
Daniel Jacobowitz wrote:
>
> On Fri, Nov 16, 2001 at 12:15:07PM -0800, Michael Snyder wrote:
> >
> > Jim,
> >
> > I presume the change below was meant as an optimization, but it's
> > based on a false assumption -- that you can't have line numbers
> > if you don't have block symbols. That premise is untrue if you
> > are debugging assembly language source, where the assembler emits
> > line syms but not block syms. This change breaks the test case
> > for assembly source debugging, gdb.asm/asm-source.exp.
> >
> > You would not have noticed, because that test only works on a few
> > targets right now (d10v being one of them).
> >
> > Patch from Peter Schauer:
> >
> > * symtab.c (find_pc_sect_line): If we can't find the function
> > containing PC, we certainly won't have line number information for
> > that location, so return zero immediately.
>
> <sigh>
>
> OK, I should have thought of that. The problem is that this almost
> always indicates a lack of debugging information, and GDB historically
> copes very badly with not having any debugging information available.
> Aside from Jim's address range cleanups, which are certainly a good
> solution for the cases they can handle, I don't know what to do about
> this.
What need are you trying to address? Is it, as I surmised, an optimization?
And if so, can we take it out until we think of a better way to do it?
Michael
next prev parent reply other threads:[~2001-11-16 22:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-07 4:59 Michael Snyder
2001-11-07 6:24 ` Daniel Jacobowitz
2001-11-07 7:59 ` Michael Snyder [this message]
2001-11-07 8:02 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF58D22.6CA0AFF9@cygnus.com \
--to=msnyder@cygnus.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox