From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4823 invoked by alias); 15 Nov 2001 16:00:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4745 invoked from network); 15 Nov 2001 16:00:36 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sourceware.cygnus.com with SMTP; 15 Nov 2001 16:00:36 -0000 Received: from redhat.com (rtl.cygnus.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA14628; Thu, 15 Nov 2001 08:00:34 -0800 (PST) Message-ID: <3BF3E676.FE6A59C3@redhat.com> Date: Tue, 06 Nov 2001 10:18:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.4.3-12 i686) X-Accept-Language: en MIME-Version: 1.0 To: Michael Snyder CC: Fernando Nasser , gdb-patches@sources.redhat.com Subject: Re: [RFA] New tests for 'const' and 'volatile' expressions References: <200111140159.fAE1xoh22447@reddwarf.cygnus.com> <3BF2E7BA.BAF8CB72@cygnus.com> <3BF2FCE7.1237E3AF@cygnus.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2001-11/txt/msg00086.txt.bz2 Michael Snyder wrote: > > Fernando Nasser wrote: > > > > Michael Snyder wrote: > > > > > > This is a test that I forgot to submit back in September, > > > after submitting the changes to the expression parser that > > > permitted more complex expressions involving const and volatile. > > > > Nice, new tests are good! > > > > > I've tested the test on several native and embedded targets. > > > > > > > Do they pass? > > Oh, yes -- no failures, when tested on the main branch. > I have not tested the 5.1 branch. If it fails, there would > be two choices: > > * merge the parser patch onto the branch > * omit this test from the branch. > > As this is a new feature, it would not make much sense have it where the feature was not yet added, right? So I would say it goes where you previous patch goes, and only there. I guess you can check it in to the trunk now. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9