From: Andrew Cagney <ac131313@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] replace register_buffer() with regcache_collect()
Date: Tue, 06 Nov 2001 03:06:00 -0000 [thread overview]
Message-ID: <3BF36390.2050605@cygnus.com> (raw)
In-Reply-To: <3BEEBC01.30409@cygnus.com>
> Hello,
>
> The attached patch replaces the function register_buffer(regnum) with regcache_collect(regnum, buffer).
>
> regcache_collect() is the counter-part to supply_register(). It extracts a single raw register from the register cache as part of processing a target_store_registers() request. Unlike register_buffer() this interface doesn't make assumptions about the underlying register cache.
>
> Targets that are directly manipulating the registers[] and register_valid[] arrays should consider themselves as being ``on notice''.
>
> Potential follow-ons to this patch are: add a ``struct regcache'' parameter; and add ``struct regcache'' to ``struct thread_info''; and parameterise target_{fetch,store}_registers() with ``struct regcache'' or ``struct thread_info''.
>
> Testing continues...
Testing has finished. Doesn't appear to break anything ....
I've added registers[] and register_valid[] to the ARI. New targets and
natives had better not use them :-)
enjoy,
Andrew
prev parent reply other threads:[~2001-11-15 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-01 7:19 Andrew Cagney
2001-11-01 10:09 ` Eli Zaretskii
2001-11-06 3:06 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF36390.2050605@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox