From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Michael Snyder Cc: gdb-patches Subject: Re: [RFA]: testsuite/gdb.base/miscexprs.* Date: Wed, 31 Oct 2001 12:32:00 -0000 Message-id: <3BE05FC2.E2BF4F87@redhat.com> References: <20011031175346.G32706@cygbert.vinschen.de> <3BE05398.C708813C@cygnus.com> X-SW-Source: 2001-10/msg00402.html Michael Snyder wrote: > > Corinna Vinschen wrote: > > > > Hi, > > > > on my target I have the same problem with the very small (2K) stack > > when running miscexprs.exp as I already had with call-ar-st.exp. > > > > I would like to propose the following patch, which adds the ability > > to extend miscexprs.exp for targets, which also suffer from the > > small stack. I added a compiler switch to define the preprocessor > > symbol `STORAGE', which by default is set to empty. A target > > specific conditional can be used for setting it to "static", to > > allow running the tests with the datastructures allocated in the > > global data area instead of on the stack. Obviously, miscexprs.exp > > in the below incarantion just contains such a conditional only for > > the target I'm just working on... > > This is a good step, and I'm in favor of accepting it. > I'd just like to suggest that an even better approach > might be to add a dejagnu variable that could be defined > in the baseboard file, rather than put a target ifdef in > the testsuite script. > > Something like this: > baseboard file: > set_board_info gdb, small_stack_section, 1 > set_board_info gdb, small_data_section, 1 // future extension > testsuite file: > if [target_info exists gdb,small_stack_section] { > set storage "-DSTORAGE=static" > } > I was simultaneously writting the same thing. Thanks Michael, small_stack_section is better than smallstack. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9