Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fernando Nasser <fnasser@redhat.com>
To: Mark Kettenis <kettenis@wins.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Handle expected failure in interrupt.exp for Linux/x86
Date: Mon, 29 Oct 2001 06:13:00 -0000	[thread overview]
Message-ID: <3BDD5E12.2A6C4AF6@redhat.com> (raw)
In-Reply-To: <200110281554.f9SFsFe11879@delius.kettenis.local>

Mark Kettenis wrote:
> 
> Ouch!  Letting GDB call a function from an interrupted restartable
> system call doesn't work on Linux/x86.  This already was an expected
> failure.  Unfortunately it only deals with a SIGSEGV wheras a SIGILL
> is just as likely.
> 
> Fixing the actual problem isn't easy.  I'll try to come up with
> something clever.  In the meantime, I'd like to check in this patch.
> 
> OK?
> 
> Mark
> 

Yes, thanks for the patch.

Fernando

> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
>         * gdb.base/interrupt.exp: Treat SIGILL similar to SIGSEGV such
>         that we catch the expected failure under Linux/x86.
> 
> Index: gdb.base/interrupt.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/interrupt.exp,v
> retrieving revision 1.3
> diff -u -p -r1.3 interrupt.exp
> --- gdb.base/interrupt.exp 2001/03/06 08:21:50 1.3
> +++ gdb.base/interrupt.exp 2001/10/28 15:46:38
> @@ -101,7 +101,7 @@ if ![file exists $binfile] then {
>         send_gdb "p func1 ()\n"
>         gdb_expect {
>             -re " = 4.*$gdb_prompt $" { pass "call function when asleep" }
> -           -re ".*Program received signal SIGSEGV.*$gdb_prompt $" {
> +           -re ".*Program received signal SIG(SEGV|ILL).*$gdb_prompt $" {
>                 setup_xfail "i*86-pc-linux*-gnu*"
>                 fail "child died when we called func1, skipped rest of tests"
>                 return

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


      reply	other threads:[~2001-10-29  6:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-28  7:54 Mark Kettenis
2001-10-29  6:13 ` Fernando Nasser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BDD5E12.2A6C4AF6@redhat.com \
    --to=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@wins.uva.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox