Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Mark Kettenis <kettenis@wins.uva.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Restructure doublest.c a bit
Date: Sun, 28 Oct 2001 11:22:00 -0000	[thread overview]
Message-ID: <3BDC5AD0.3020706@cygnus.com> (raw)
In-Reply-To: <200110281239.f9SCdOk08291@delius.kettenis.local>

Yes fine.

> +
> +  /* FIXME: kettenis/2001-10-06: It is debatable whether we should
> +     zero out any remaining bytes in the target buffer when TYPE is
> +     longer than the actual underlying floating-point format.  Perhaps
> +     we should store a fixed bitpattern in those remaining bytes,
> +     instead of zero, or perhaps we shouldn't touch those remaining
> +     bytes at all.  */
> 

Can you add this:

/* NOTE: cagney/2001-10-28: With the way things currently work, it isn't 
a good idea to leave the end bits undefined.  This is because GDB writes 
out the entire sizeof(<float>) bits of the floating point type even 
though the value might only be stored in, and the target processor may 
only refer to, the first N<LENGTH bits.  If the end of the buffer wasn't 
initialized, GDB would write undefined data to the target.  An errant 
program, refering to that undefined data, would would become 
non-deterministic.  */

enjoy,
	Andrew



  reply	other threads:[~2001-10-28 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-28  4:39 Mark Kettenis
2001-10-28 11:22 ` Andrew Cagney [this message]
2001-10-28 14:06 Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BDC5AD0.3020706@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@wins.uva.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox