Re: [PATCH] xcoffread.c: remove include of partial-stab.h

[Andrew Cagney <ac131313@cygnus.com>]

> I know this file has no official maintainer, but I'll wait a few days
>> to check it in anyway.
> 
> 
> I've looked this patch over.  I've verified that only two cases of
> partial-stab.h were needed by xcoffread.c.  Also, it appears to me
> that you've correctly integrated the two necessary cases into
> xcoffread.c.
> 
> My only concern about this patch is with the duplication of the two
> cases in xcoffread.c.  These hunks of code are of substantial size and
> it occurs to me that correct maintenance of this code may require
> keeping the various copies in sync.  I'm wondering if it'd be possible
> to turn these hunks of code into functions.  That way we might be able
> to avoid duplicating (some of) this code in three different places.

I think pragmatism being applied to this patch should be the same as for 
the aout vs svr4 solib code.

Yes in theory, there is common code that could be abstracted out.  In 
reality, I think there is zero benefit.  Instead all the xcoffread stuff 
can be confined to a single file where it can be ignored (and hopefully 
eventually deleted).

enjoy,
Andrew