From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: Don Howard <dhoward@redhat.com>, gdb-patches@sources.redhat.com, Fernando Nasser <fnasser@redhat.com>, Michael Snyder <msnyder@cygnus.com>
Subject: Re: [RFA] deleting breakpoints inside of 'commands' [Repost]
Date: Mon, 24 Sep 2001 18:52:00 -0000
Message-id: <3BAFE360.9080904@cygnus.com>
References: <Pine.LNX.4.33.0109211638230.1755-100000@theotherone> <1010925001014.ZM30380@ocotillo.lan>
X-SW-Source: 2001-09/msg00326.html

> 
> I've looked your patch over, and it looks correct to me.  Having said
> that, I think that the correctness of this patch is much less obvious
> than the version that made a copy of the command chain associated with
> a breakpoint.  I don't fault you for this; the changes in your current
> patch are somewhat more distributed which means that there's more code
> to consider (and more ways for something to get fouled up later on).

And guess what (sorry but this is funny :-) I suspect it does contain a 
bug.  Try:

	break main
	commands
	delete NN
	leak-memory
	end


The command ``leak-memory'' is invalid and will lead to an error() call 
and that will in turn long jump over the code that would free the list.

While the duplicate version contains the same bug, I suspect it is 
easier to fix vis:

	o	duplicate list
	o	add list to a cleanup
	o	run command
	o	do cleanups

I suspect to do this with the non-duplicate version you'll need to add a 
catch_exceptions() call (nee catch_errors()) and check the state of that 
->execute variable to figure out what to do.

I do tend to agree with Kevin though.  Some times simplicity is best.

Andrew