From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] solib-svr4.c: Fix set_solib_svr4_fetch_link_map_offsets Date: Fri, 21 Sep 2001 18:56:00 -0000 Message-id: <3BABEFC7.9020100@cygnus.com> References: <1010920205607.ZM17368@ocotillo.lan> X-SW-Source: 2001-09/msg00295.html > As a heads up though, one of the problems is that solib-svr4.c > actually contains (ifdef'd) shared library support for both SVR4 and > SunOS. I will be disentangling these mechanisms and will place SunOS > shared library support in its own file. That way we'll be able to do > away with the SVR4_SHARED_LIBS macro and we won't accidentally attempt > to ever include from solib-svr4.c any longer. To be honest, I've been very tempted to solve this problem using a very brutal approach: take solib-svr4.c, copy it to solib-aout.c, strip out/in SVR4-SHARED_LIBS code, and then tweek the config files to use either. I think this is one of those cases where the desire to re-use the code was taken a little to far - better to get the interfaces right and have a clear separation. Who cares about a little duplication :-) enjoy, Andrew