From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Andrew Cagney Cc: Michael Snyder , Don Howard , gdb-patches@sources.redhat.com Subject: Re: [RFA] deleting breakpoints inside of 'commands' [Repost] Date: Tue, 18 Sep 2001 08:09:00 -0000 Message-id: <3BA7628F.371ABBDD@redhat.com> References: <3BA67BAA.825A5957@cygnus.com> <3BA7519F.70E25EC3@redhat.com> <3BA7608F.3040104@cygnus.com> X-SW-Source: 2001-09/msg00234.html Andrew Cagney wrote: > > >> Is it worth the effort? Is this duplication costly > >> compared to everything else already being done by > >> bpstat_do_actions? Or am I worrying over nothing? > > I think this is in the noise. GDB has performance problems with very > large symbol files, it doesn't have problems with 3 line breakpoint scripts. > Why 3 line? There are very long breakpoint scripts around. Furthermore, when using breakpoint scripts to track some bugs (sometimes "condition" is not enough) it may be desirable to minimize the artifact. > > I share your concerns. And I see no reason why this should be allowed > > -- > > the script can always "disable" its own breakpoint with the same effect > > for all practical purposes. > > > > A patch adding a "cannot delete self" error message would be nice. > > I would really rather not see GDB introduce, undocumented, edge > conditions like this. I think the patch Don submitted had the very nice > effect of eliminating the need for such a special case. > If at least it would make the copy only when needed (i.e., when someone is trying to delete the breakpoint that has the script attached on it) things would not be that bad. Michael, do you remove your objection or does it still stands after Andrew's arguments? -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9