From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: gdb-patches Subject: Re: [PATCH]: testsuite/gdb.base/ending-run.* Date: Tue, 18 Sep 2001 07:57:00 -0000 Message-id: <3BA75FE1.C13959A2@redhat.com> References: <20010912164628.T1285@cygbert.vinschen.de> <3BA74BF3.97D7C650@redhat.com> <20010918164242.A28304@cygbert.vinschen.de> X-SW-Source: 2001-09/msg00232.html Corinna Vinschen wrote: > > On Tue, Sep 18, 2001 at 09:28:19AM -0400, Fernando Nasser wrote: > > Thanks for the patch. > > > > It is approved with a small change (see below). It is OK fr the tests > > to expect alternative patterns depending on the target, but the > > test identification must remain the same nevertheless (it would > > confuse people's test result analysis scripts otherwise). > > The reference that matches the pattern to the architecture must > > be on the comment (only). > > > > Regards, > > Fernando > > > > P.S.: It is OK to still say "ARM thumb" as ARM is the reference > > architecture > > that is licensed by chip manufacturers (it is still ARM at the core). > > I'm sorry about that. It's not an ARM in thumb mode. I just > copied the text from the case below and didn't remove the "thumb" > text. It should be > > pass "step out of main on Stormy16" > > Still ok? > No, all the "pass" statements (as well as the "fail", "xfail" etc.) must have the same test id string. In this case, all the "-re" patterns must result in a "pass" or "fail" with that same string (except that the "fail" may have a reason between parenthesis after the test id string, like "(timeout)" for instance). -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9