From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Snyder <msnyder@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: correctly detect overlapping overlays
Date: Mon, 13 Aug 2001 11:25:00 -0000
Message-id: <3B781A72.2C29AB2@cygnus.com>
References: <20010812184312.C90245E9DA@zwingli.cygnus.com> <3B7737C3.8070805@cygnus.com> <npofpkt44n.fsf@zwingli.cygnus.com>
X-SW-Source: 2001-08/msg00142.html

Jim Blandy wrote:
> 
> Andrew Cagney <ac131313@cygnus.com> writes:
> > > +   CORE_ADDR a_start = a->vma;
> > > +   CORE_ADDR a_end   = a->vma + bfd_get_section_size_before_reloc (a);
> > > +   CORE_ADDR b_start = b->vma;
> > > +   CORE_ADDR b_end   = b->vma + bfd_get_section_size_before_reloc (b);
> >
> >
> > Jim, just a reminder on coding style.
> > There isn't any reason to (and probably good reason to not) lay out the
> > code so carefully.  It just makes the task of someone running indent
> > over the code all the more confusing.
> 
> I hadn't thought of people running indent.  I'll fix that.
> 
> But I do think it's a shame.  When layout can expose symmetry in what
> you're doing, it makes it easier to read the code.

I agree, I like to do the kind of formatting that jim is doing.