From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Daniel Jacobowitz Cc: Kevin Buettner , gdb-patches@sources.redhat.com Subject: Re: [rfa/ppc/branch too] Fix PowerPC/Linux cores Date: Tue, 31 Jul 2001 08:50:00 -0000 Message-id: <3B66D3A5.10203@cygnus.com> References: <20010730142328.A6323@nevyn.them.org> <1010730224404.ZM5571@ocotillo.lan> <20010730155455.A3552@nevyn.them.org> <1010731004934.ZM5803@ocotillo.lan> <20010730175738.A23859@nevyn.them.org> X-SW-Source: 2001-07/msg00755.html >> Before you commit anything along these lines (or along the lines of >> the patch that you submitted), do check with Andrew first. I'm not >> the core-regset.c maintainer and Andrew may want to see all patches >> that go in on the release branch go in on the trunk as well... > > > OK. In that case, I think the right thing to do would be: > - remove the #ifdefs > - change to the gdb_*regset_t functions > On both branch and trunk. I thought more platforms had custom > GDB_GREGSET_T definitions, but I guess not. > > It's closer to overall right, and it will still go away in a reasonable > amount of time. I'd rather not diverge the branch and truck if I don't > have to. > > Andrew, how's that sound? Well, the one thing I don't want is hacks pulled on the branch that aren't matched in the trunk - people will assume bugs are fixed when they are not. Pulling the same tweek on both is ok. Beyond that it is between you and Kevin. Andrew