From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Force suppression of Insight test Date: Mon, 23 Jul 2001 11:22:00 -0000 Message-id: <3B5C6A91.F47A986E@cygnus.com> References: X-SW-Source: 2001-07/msg00572.html Keith Seitz wrote: > > Hi, > > The following patch will allow developers to specifically skip insight > tests by setting the environment variable "GDB_DISPLAY" to "": > > $ GDB_DISPLAY="" make RUNTESTFLAGS="console.exp" check > > (By default, the testsuite will look for Xvfb if GDB_DISPLAY is not set or > it will use DISPLAY=$GDB_DISPLAY if it is set and not empty.) > > Keith > Approved. Thanks Keith. Fernando > ChangeLog > 2001-07-22 Keith Seitz > > * lib/gdb.exp (_gdbtk_xvfb_init): If GDB_DISPLAY is > the empty string, do not run the tests. > > Patch > Index: testsuite/lib/gdb.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v > retrieving revision 1.9 > diff -u -p -r1.9 gdb.exp > --- gdb.exp 2001/06/14 00:12:32 1.9 > +++ gdb.exp 2001/07/22 15:54:48 > @@ -1698,14 +1698,19 @@ proc gdbtk_start {test} { > > # Start xvfb when using it. > # The precedence is: > -# 1. If GDB_DISPLAY is set, use it > +# 1. If GDB_DISPLAY is set (and not ""), use it > # 2. If Xvfb exists, use it (not on cygwin) > # 3. Skip tests > proc _gdbtk_xvfb_init {} { > global env spawn_id _xvfb_spawn_id _using_windows > > if {[info exists env(GDB_DISPLAY)]} { > - set env(DISPLAY) $env(GDB_DISPLAY) > + if {$env(GDB_DISPLAY) != ""} { > + set env(DISPLAY) $env(GDB_DISPLAY) > + } else { > + # Suppress tests > + return 0 > + } > } elseif {!$_using_windows && [which Xvfb] != 0} { > set screen ":[getpid]" > set pid [spawn Xvfb $screen] -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9