From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Stephen Smith <ischis2@home.com>
Cc: Elena Zannoni <ezannoni@cygnus.com>, GDB patches <gdb-patches@sourceware.cygnus.com>, Kevin Buettner <kevinb@cygnus.com>
Subject: Re: Re-submit: shared libraries and a remote target
Date: Fri, 20 Jul 2001 17:52:00 -0000
Message-id: <3B58D249.1020100@cygnus.com>
References: <3B55CD58.13771694@home.com> <15189.59080.526458.935802@krustylu.cygnus.com> <3B575CCC.E4B5E759@home.com> <3B586202.2E1504ED@home.com> <3B58CA4D.FE9AAD02@home.com>
X-SW-Source: 2001-07/msg00540.html

> This patch supersedes http://sources.redhat.com/ml/gdb-patches/2001-07/msg00513.html .
> It has all of Elena's and Kevin's comments implemented.
> 
> 
>         * remote.c (remote_get_list_of_shared_libraries, find_file,
>         parse_string_from_server): New functions which support
>         an optional extension to the remote protocol.


Hmm, I suspect the ChangeLog needs to be fleshed out a little.

You didn't mention anything about the remote_protocol_qLibraries global 
variable or the associated functions.  This is a shame because all that 
is fine!


> +#include <string.h>


FYI, gdb uses "gdb_string.h".  Also mention this in the ChangeLog.


> +  remote_get_list_of_shared_libraries();


FYI ``foo ()'' not ``foo()''


> +static void
> +remote_get_list_of_shared_libraries (void)


These new function should be before _initialize*().

Taking a quick glance at the actual code, I suspect that once the 
protocol is sorted out much of this will be simplified.

	Andrew