Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa] mips heuristic_proc_start fix
Date: Thu, 12 Jul 2001 14:35:00 -0000	[thread overview]
Message-ID: <3B4E1810.2030807@cygnus.com> (raw)
In-Reply-To: <20010712141905.A29671@nevyn.them.org>

> 
> Nope!  We just read pc off the stack.  If the PC is legitimate in the
> first place, none of these nasty loops are a problem.  My pc was 0x2;
> that's bad, but not cause for gdb to die.  What'd you say to a warning
> and early return?


(Technically, before the call to ADDR_BITS_REMOVE() both 3 and 1 are 
valid, after 2 is valid - MIPS16 code.  :-)

I think just having the one message is easier.  As the comment notes:

                 /* This actually happens frequently in embedded
                    development, when you first connect to a board
                    and your stack pointer and pc are nowhere in
                    particular.  This message needs to give people
                    in that situation enough information to
                    determine that it's no big deal.  */

so any other message would need to be just as long.

	Andrew


      reply	other threads:[~2001-07-12 14:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-06 11:20 Daniel Jacobowitz
2001-07-06 11:27 ` Andrew Cagney
2001-07-06 11:32   ` Daniel Jacobowitz
2001-07-06 11:40     ` Daniel Jacobowitz
2001-07-12  0:47       ` Andrew Cagney
2001-07-12 12:14         ` Daniel Jacobowitz
2001-07-12 14:11           ` Andrew Cagney
2001-07-12 14:19             ` Daniel Jacobowitz
2001-07-12 14:35               ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B4E1810.2030807@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=dmj+@andrew.cmu.edu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox