From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa] mips argument passing fixes for o32 Date: Thu, 12 Jul 2001 11:59:00 -0000 Message-id: <3B4DF3A9.8010205@cygnus.com> References: <20010706112635.A5870@nevyn.them.org> <3B4D5E95.6010407@cygnus.com> <20010712103946.C6359@nevyn.them.org> X-SW-Source: 2001-07/msg00302.html >> I don't think this change is right. In little endian mode, a one byte >> struct will end up being stored at A+4 instead of A. >> >> Which failures did it appear to fix? Which endian is MIPS/Linux? > > > MIPS/Linux can be either big or little endian; the failure was on > little endian. > > The effect is to store a one byte struct at A+3 (not A+4); this matches > what at least GCC does from what I can tell, and the comment in GCC > says that SGI compilers do the same. (A+3, yes, sorry). The SGI compilers are big endian (correct?) so who knows what they would do in the little endian case. > The testcase was the passing of a three_char_t in call-ar-st (calling > print_three_chars from the gdb prompt). This is going to take more digging. It smells like a GCC bug. It is definitly inconsistent with other ABIs where the struct is always stored at A and not A+3. Andrew