From: Andrew Cagney <ac131313@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/doc] Update ui-out; Was: [patch] Add col_name to ui_out_table_header()
Date: Fri, 06 Jul 2001 15:20:00 -0000 [thread overview]
Message-ID: <3B4639A2.2070205@cygnus.com> (raw)
In-Reply-To: <Pine.SUN.3.91.1010705095541.15332N-100000@is>
Eli,
I think I got all of these. Keep an eye out for the @pxref{} and
@footnote{}.
Andrew
> ! @subsection Table, Tuple and List Functions
>> > @cindex list output functions
>> @cindex table output functions
>> ! This section introduces @code{ui_out} routines for building lists,
>> ! tuples and tables. The routines to output the actual data items
>> ! (fields) are presented in the next section.
>
>
> Please add here a @cindex entry about "tuple output functions".
>
>
>> ! To recap: A @dfn{tuple} is a sequence of @dfn{fields}, each field
>> ! containing information about an object; A @dfn{list} is a sequence of
>
>
> This "A" after a semi-colon should be a lower-case "a".
>
>
>> ! @code{ui_out_table_end}. The tuples are produce by calling
>
>
> "The tuples are produced"
>
> Btw, I don't understand why did you consistently change active into
> passive tense. Compare the old text:
>
> You produce the lists by calling
> @code{ui_out_list_begin} and @code{ui_out_list_end}, with suitable
> calls to functions which actually output fields between them.
>
> with the new:
>
> The tuples are produced by calling
> @code{ui_out_tuple_begin} and @code{ui_out_tuple_end}, with suitable
> calls to functions which actually output fields between them.
>
> English is not my first language (not even the second, actually), but
> I know RMS always corrects my passive-tense sentences.
>
>
>> ! @deftypefun void ui_out_tuple_begin (struct ui_out *@var{uiout}, const char *@var{lstid})
>> ! This function marks the beginning of a tuple output. @var{lstid} points
>> ! to an optional string that identifies the list; it is copied by the
>
> ^^^^
> Shouldn't this say "tuple" rather than "list"?
>
>
>> ! @deftypefun void ui_out_tuple_end (struct ui_out *@var{uiout})
>> ! This function signals an end of a list output. There should be exactly
>
> ^^^^
> Same here.
>
>
>> ! @deftypefun struct cleanup *make_cleanup_ui_out_tuple_begin_end (struct ui_out *@var{uiout}, const char *@var{id})
>> ! This function opens a tuple and then installs a cleanup to close that
>> ! same tuple.
>
>
> I think we should explain here what does "installs a cleanup to close
> that same tuple" mean, and why this function is useful. A
> cross-reference to the Cleanups section would also help (but it cannot
> be enough to explain why this function was introduced, since the
> Cleanups section is very short and doesn't really explain the purpose
> of cleanups in a clear manner.)
>
>
>> + @deftypefun struct cleanup *make_cleanup_ui_out_list_begin_end (struct ui_out *@var{uiout}, const char *@var{id})
>> + This function opens a list and then installs a cleanup to close that same
>> + list.
>> + @end deftypefun
>
>
> Same here.
>
>
next prev parent reply other threads:[~2001-07-06 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-21 8:37 Andrew Cagney
2001-06-22 1:35 ` Eli Zaretskii
2001-07-04 17:30 ` [rfa/doc] Update ui-out; Was: " Andrew Cagney
2001-07-04 23:54 ` Eli Zaretskii
2001-07-05 19:40 ` Andrew Cagney
2001-07-06 1:31 ` Eli Zaretskii
2001-07-06 15:20 ` Andrew Cagney [this message]
2001-07-06 22:53 ` Eli Zaretskii
2001-07-07 9:16 ` Andrew Cagney
2001-07-07 9:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B4639A2.2070205@cygnus.com \
--to=ac131313@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox