From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Add mips_software_single_step
Date: Thu, 05 Jul 2001 14:50:00 -0000
Message-id: <3B44E116.4070009@cygnus.com>
References: <20010704115630.A16310@nevyn.them.org>
X-SW-Source: 2001-07/msg00118.html

> This function's pretty straightforward; the Linux port uses it.  Ok to
> commit?


How does the linux port use it?  As a tweek to the multi-arch vector or 
as a macro/function?  If the former then it should be static, if the 
latter than a declaration in mips-tdep.h or tm-mips.h (?) is needed.


> I've been tempted to redo this more like the Sparc's version, in which we
> set breakpoints at all possible destinations rather than at the calculated
> next destination.  But I think that with the previously posted patch, I
> trust mips_next_pc enough to leave it this way.


The function is almost ok.  It just needs to be updated to meet GDB's 
current coding conventions (ISO-C, indentation).

With regard to the linux code, you should probably look over 
http://sources.redhat.com/gdb/ari/ and check any new code for potential 
regressions or errors.  Just remember to ignore any of the warnings :-)

	Andrew