Re: [rfa/i387] Eliminate HOST_*_FORMAT from i387-tdep.c

Mark Kettenis
2001-07-01T05:56:00Z

Andrew Cagney <ac131313@cygnus.com> writes:

> Hello,
>
> Very similar to my ARM tweek, this patch replaces a use of
> HOST_LONG_DOUBLE_FORMAT with more generic code.
>
> There isn't a loss of precision since extract_floating() on i386 native
> should still do a memcopy().

Hmm, the new code seems to assume that

TARGET_LONG_DOUBLE_FORMAT == &floatformat_i387_ext

This isn't true for OSF/1, but that target doesn't use this code (and
probably doesn't compile anyway). Nevertheless, I think you should
add a

gdb_assert (TARGET_LONG_DOUBLE_FORMAT == &floatformat_i387_ext);

instead of, or in addition to the

gdb_assert (FPU_REG_RAW_SIZE < len);

Consider it approved with that change.

Oh, and I believe the GNU coding standards demand two spaces after a
full stop, even at the end of a comment.

Mark