From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC]: New dwarf2 reader
Date: Thu, 28 Jun 2001 23:35:00 -0000 [thread overview]
Message-ID: <3B3C219C.3000506@cygnus.com> (raw)
In-Reply-To: <87pubnluqa.fsf@cgsoftware.com>
Dan,
For such a radical change to fly, I think this should be a runtime
replacement for the existing dwarf2 reader.
That way people can test the two side by side. It will give people
greater confidence and an easy reference point.
Some trivia:
> #ifndef DWARF2_REG_TO_REGNUM
> #define DWARF2_REG_TO_REGNUM(REG) (REG)
> #endif
this shouldn't be needed. If it is then there is a bug in multi-arch.
> #if defined(HAVE_MMAP) && defined(HAVE_GETPAGESIZE)
> #include <sys/mman.h>
> #endif
It should be posible to structure things so those #if #else #endif's are
largely eliminated. You want as much of your code to be exposed to the
C (not C++ :-) compiler at all times. That mysterious #if D2FIX is
similar. Does bfd already provide an MMAP facility?
You'll eventually want to go over the code with a fine tooth comb -
flush out the naughtness in the old dwarf2reader and eliminate the
neuances you, your self have introduced.
Andrew
next prev parent reply other threads:[~2001-06-28 23:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-28 22:29 Daniel Berlin
2001-06-28 23:35 ` Andrew Cagney [this message]
2001-06-29 8:42 ` Andrew Cagney
2001-06-29 9:03 ` Daniel Berlin
2001-06-29 14:05 ` Michael Snyder
2001-06-29 19:34 ` Daniel Berlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B3C219C.3000506@cygnus.com \
--to=ac131313@cygnus.com \
--cc=dan@cgsoftware.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox