From: Andrew Cagney <ac131313@cygnus.com>
To: Don Howard <dhoward@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips fp register display
Date: Sat, 23 Jun 2001 11:09:00 -0000 [thread overview]
Message-ID: <3B34DB58.1000904@cygnus.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0106211530030.1795-100000@theotherone>
Don,
Approved with notes. At least this fixes the most common case and
gets GDB to print out the correct value. Fixing the case where GDB is
three levels down on a stack frame is a different problem.
> + /* Otherwise check the FR bit in the status register - it controls
> + the fp compatiblity mode */
> + return !(read_register (PS_REGNUM) & 1 << 26);
>
Is there a constant with ``1 << 26'' in it somewhere? If not, can you
please add one. Also, some extra paren so I don't need to strain my
brain trying to figure out the operator order is useful.
Andrew
next prev parent reply other threads:[~2001-06-23 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-21 14:41 Don Howard
2001-06-21 16:01 ` Daniel Jacobowitz
2001-06-22 10:26 ` Don Howard
2001-06-23 11:03 ` Andrew Cagney
2001-06-23 11:09 ` Andrew Cagney [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-05-10 10:48 [RFA] Mips " Don Howard
2001-03-27 1:01 Don Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B34DB58.1000904@cygnus.com \
--to=ac131313@cygnus.com \
--cc=dhoward@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox