Re: [patch] read_command_lines can return freed memory

Fernando Nasser
2001-06-15T12:04:00Z

Thanks for testing it and for the test case.

If you agree, I will modify your changelog entry to:

2001-06-15 Eirik Fuller <eirik@hackrat.com>

* cli/cli-script.c (free_command_lines): Reset list pointer.

and check the second version of the patch in.

And thanks again for the bug report/fix.

Regards,
Fernando

Eirik Fuller wrote:
>
> I backed out the patch to read_command_lines, confirmed that the crash
> occurs again, applied the patch to free_command_lines, and confirmed
> that the crash no longer occurs.
>
> I agree that patching free_command_lines is the right way to fix this.
>
> > we should think of a more contrived example to create a test case...
>
> Here's the simplest test case I've found which triggers the crash:
>
> define f0
> set $f = $arg0
> if $f[1]
> if $f[2]
> f2
> else
> f1
> else
>
> You can also add stuff after the second else. As before, source that
> file twice; the second time triggers the crash. It's likely that the
> details of the crash (including whether it occurs at all) vary from
> platform to platform; I'm using a Debian x86 system with libc6 2.2.3.
>
> Thanks,
> Eirik

--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com