Re: PATCH: resume + threads + software stepping == boom

Daniel Jacobowitz
2001-06-08T14:10:00Z

On Fri, Jun 08, 2001 at 12:34:32PM -0700, Daniel Jacobowitz wrote:
> resume () in infrun.c has this block:
>
> if (SOFTWARE_SINGLE_STEP_P () && step)
> {
> /* Do it the hard way, w/temp breakpoints */
> SOFTWARE_SINGLE_STEP (sig, 1 /*insert-breakpoints */ );
> /* ...and don't ask hardware to do it. */
> step = 0;
>
> Then, further down, if (use_thread_step_needed && thread_step_needed)
> and there's already a breakpoint at the PC, is this:
>
> if (!step)
> {
> warning ("Internal error, changing continue to step.");
>
> That blows up, because step will always be zero here if
> SOFTWARE_SINGLE_STEP_P (). Is this patch OK? It seems to work in my tests
> here.

Oops, forgot a changelog entry for this one.

2001-06-08 Daniel Jacobowitz <drow@mvista.com>
* infrun.c (resume): Add ostep variable. Test ostep
instead of step.

--
Daniel Jacobowitz Debian GNU/Linux Developer
Monta Vista Software Debian Security Team