From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Elena Zannoni Cc: Jim Blandy , Daniel Berlin , gdb-patches@sources.redhat.com Subject: Re: [RFA] linespec.c change to stop "malformed template specification" error Date: Thu, 07 Jun 2001 12:30:00 -0000 Message-id: <3B1FD645.8839904D@cygnus.com> References: <87ofsldrgr.fsf@dynamic-addr-83-177.resnet.rochester.edu> <15134.47162.825017.119342@kwikemart.cygnus.com> <15135.37463.301545.370875@kwikemart.cygnus.com> <15135.47501.950878.977558@kwikemart.cygnus.com> X-SW-Source: 2001-06/msg00151.html Elena Zannoni wrote: > > Yes, you are correct. That function (find_toplevel_char) would get it wrong > if we had something like this, even with Dan's patch: > > break foo_classy ? 1 : 2, 4>::foo > > It would think that the greater-than was the end of the template, and > that the ',' was outside of the template specification. But, if that > is a legal expression (I am not sure), how likely would it be? > Definitely better with Dan's patch than w/o, at least we can catch the > simpler cases. > > Elena That is what I think. It may not make it perfect (as I said, linespec will never be perfect), but it makes it better than before. -- Fernando Nasser Red Hat - Toronto E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9