Re: [PATCH RFA] gdb.base/finish.exp: Allow finish to stop on call

Michael Snyder
2001-05-23T19:56:00Z

Fernando Nasser wrote:
>
> Kevin Buettner wrote:
> >
> > On May 23, 8:18pm, Fernando Nasser wrote:
> >
> > > Your second pattern needs a small improvement though. As we are
> > > returning to the middle of that source line, the information printed by
> > > GDB will have the address (PC) as well. We must make sure that we test
> > > for that so we can differentiate between returning to the beginning of
> > > the calling line (wrong) and returning to after where the assembler jump
> > > to subroutine was (right). You can test for that without binding to a
> > > specific PC value -- there are several examples around.
> > >
> > > After making this change, and testing that it works, of course, you can
> > > commit your patch. Please post the final version for the records.
> >
> > The patch you refer to has already been committed. (Michael S. approved
> > it.)
> >
>
> Michael got confused, he can checkin anywhere but can only approve
> patches to gdb.trace and gdb.threads (for now, at least).

But... but... I wrote that test! ;-)