From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stan Shebs To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] use memset to zero the fields of a new frame_info Date: Thu, 17 May 2001 13:24:00 -0000 Message-id: <3B04330A.21E8784E@apple.com> References: <3B042FD4.81EE2FC3@cygnus.com> X-SW-Source: 2001-05/msg00348.html Michael Snyder wrote: > > One call to memset does a better job than some number of individual assigns, > esp. since it's guaranteed to get new fields that would be missed otherwise > (and were being). > > 2001-05-17 Michael Snyder > > * blockframe.c (create_new_frame): Zero all the fields via memset, > rather than zeroing them one by one. Ah, the end of an era. Gilmore originally objected to this kind of thing, on the theory that it was "machine-gunning" memory and wasn't necessary - only set fields that you know need to be zeroed. I'm on the fence, because it can save bugs and random scattered init code if you can assume that newly-allocated data all has known values, and clearing small-to-medium-size structs isn't expensive usually. In any case, the policy ought to be clarified one way or the other. Stan