Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@cygnus.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] use memset to zero the fields of a new frame_info
Date: Thu, 17 May 2001 13:08:00 -0000	[thread overview]
Message-ID: <3B042FD4.81EE2FC3@cygnus.com> (raw)

One call to memset does a better job than some number of individual assigns, 
esp. since it's guaranteed to get new fields that would be missed otherwise
(and were being).



2001-05-17  Michael Snyder  <msnyder@redhat.com>

        * blockframe.c (create_new_frame): Zero all the fields via memset,
        rather than zeroing them one by one.

Index: blockframe.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/blockframe.c,v
retrieving revision 1.111
diff -c -3 -p -r1.111 blockframe.c
*** blockframe.c        2001/05/09 00:19:04     1.111
--- blockframe.c        2001/05/17 19:59:08
*************** create_new_frame (CORE_ADDR addr, CORE_A
*** 219,228 ****
      obstack_alloc (&frame_cache_obstack,
                   sizeof (struct frame_info));
  
    /* Arbitrary frame */
-   fi->saved_regs = NULL;
-   fi->next = NULL;
-   fi->prev = NULL;
    fi->frame = addr;
    fi->pc = pc;
    find_pc_partial_function (pc, &name, (CORE_ADDR *) NULL, (CORE_ADDR *) NULL);
--- 219,227 ----
      obstack_alloc (&frame_cache_obstack,
                   sizeof (struct frame_info));
  
+   /* Zero all fields by default.  */
+   memset (fi, 0, sizeof (struct frame_info));
    /* Arbitrary frame */
    fi->frame = addr;
    fi->pc = pc;
    find_pc_partial_function (pc, &name, (CORE_ADDR *) NULL, (CORE_ADDR *) NULL);


             reply	other threads:[~2001-05-17 13:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-17 13:08 Michael Snyder [this message]
2001-05-17 13:24 ` Stan Shebs
2001-05-17 21:04   ` Andrew Cagney
2001-05-20 13:06     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B042FD4.81EE2FC3@cygnus.com \
    --to=msnyder@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox