Re: [RFA] Remote symbol look-up (resubmission)

Michael Snyder
2001-05-11T18:51:00Z

Eli Zaretskii wrote:
>
> > Date: Fri, 11 May 2001 10:25:57 -0700
> > From: Michael Snyder <msnyder@cygnus.com>
> >
> > This is a re-submission, with documentation and changes to answer Andrew's concerns.
> >
> >
> > 2001-05-10 Michael Snyder <msnyder@redhat.com>
> >
> > * solib.h (no_shared_libraries): Export definition.
> > * remote.c (remote_new_objfile): New function. Called whenever
> > a new objfile is created (which is generally a new shared library).
> > (remote_check_symbols): Send notification to the target that it is
> > now a good time to ask for symbol look-up service, and handle any
> > symbol look-up requests. Called whenever a new symbol file becomes
> > available, and from remote open.
> > (hex2bin): Require explicit count, don't accept null-terminated str.
> > (set_remote_protocol_qSymbol_packet_cmd): New function.
> > (show_remote_protocol_qSymbol_packet_cmd): New function.
> > (remote_open_1, remote_async_open_1): Call remote_check_symbols.
> > (_initialize_remote): Hook remote_new_objfile into the new
> > objfile notification chain. Add set/show remote symbol-lookup
> > commands.
> > * doc/gdb.texinfo: Document the new 'qSymbol' and 'QSymbol' packets.
>
> The changes to gdb.texinfo are approved, but please correct one minor
> problem:
>
> > + @tab @code{q}@code{Symbol:}@var{SYMBOL_FILE_NAME}
>
> Please write the arguments of @var{} in lower case. They will be
> converted to upper case by makeinfo, but in the printed manual @var is
> typeset with a special font which makes it stand out without upcasing
> the text. (There are several other places which use @var{FOO}.)

OK.