From: Fernando Nasser <fnasser@redhat.com>
To: Elena Zannoni <ezannoni@cygnus.com>
Cc: gdb-patches@sources.redhat.com, hilfingr@otisco.mckusick.com
Subject: Re: RFA: [symfile.c} Fix to symbol_file_add() [REPOST]
Date: Wed, 02 May 2001 09:43:00 -0000 [thread overview]
Message-ID: <3AF038C1.A4B357E1@redhat.com> (raw)
In-Reply-To: <15088.12423.711167.908434@kwikemart.cygnus.com>
Elena Zannoni wrote:
>
> Thanks Fernando!
> But shouldn't we be leaving the stuff in symbol_file_command?
> I.e. only adding it to the new function?
>
Yes, of course. It calls symbol_file_add(), not symbol_file_add_main()
because of the flags. Silly me.
Yes, please consider the patch without the removal part.
P.S.: I guess symbol_file_add_main() should have the flags argument,
but I guess this thing has been going on for too long now for me to go
after all callers and add the argument.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
next prev parent reply other threads:[~2001-05-02 9:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-30 8:25 RFA: [symfile.c} Fix to symbol_file_add() Fernando Nasser
2001-04-30 11:28 ` Elena Zannoni
2001-04-30 16:36 ` Fernando Nasser
2001-04-30 20:29 ` Elena Zannoni
2001-05-01 5:51 ` Fernando Nasser
[not found] ` <15087.31793.429533.289522@kwikemart.cygnus.com>
2001-05-02 8:55 ` RFA: [symfile.c} Fix to symbol_file_add() [REPOST] Fernando Nasser
[not found] ` <15088.12423.711167.908434@kwikemart.cygnus.com>
2001-05-02 9:43 ` Fernando Nasser [this message]
2001-05-02 10:26 ` Elena Zannoni
2001-05-02 11:06 ` Fernando Nasser
2001-05-07 9:08 Fernando Nasser
2001-05-10 8:34 ` Fernando Nasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AF038C1.A4B357E1@redhat.com \
--to=fnasser@redhat.com \
--cc=ezannoni@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=hilfingr@otisco.mckusick.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox