Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com, jtc@redback.com
Subject: Re: [RFC] Extend remote protocol to allow symbol look-up service.
Date: Thu, 26 Apr 2001 14:26:00 -0000	[thread overview]
Message-ID: <3AE8928A.18E07030@cygnus.com> (raw)
In-Reply-To: <3AE21A6E.EEFBF3CC@cygnus.com>

Andrew Cagney wrote:
> 
> Just FYI,
> 
> Some quick comments on the protocol as it currently stands.  I'd suggest
> waiting until the actual protocol spec has been resolved first though.
> 
>         Andrew
> 
> --
> 
> >         QSharedObject:libc.so.1
> 
> Given that the replies are:
> 
>         ""
>         OK
>         Some value
> 
> I would strongly prefer the ``q'' packet over the ``Q'' packet (I think
> the latter is redundant :-).  The ``q'' packet implicitly allows a value
> to be returned - which in turn gives the RPC mechanims that you're
> implementing.

You keep calling it 'rpc'.  I don't see how it is rpc.  It's just a query.
But I don't mind changing it from 'Q' to 'q', even though it doesn't make
sense to me.  The shared library message is more of a notification than
a query, I think.

> The symbol and file value is being passed as ascii text.  I think they
> should be hex encoded so that we're 100% certain that they will never
> contain unprintable or protocol data.  This was the rationale behind the
> qRcmd packet carrying HEX data.

Does anyone else have an opinion?  I don't like unreadable messages.

> Is the protocol stateless?  That is, would repeating the query:
> 
>         qSymbol::__pthread_max_threads
> 
> always return the same value?

It's not stateless; both the target and the debugger have state.
On the debugger, the 'state' is whether the symbol is available or not.
On the target, the state is whether this symbol's value has been obtained.
Also whether it has been requested since the last shared library event.
The target should ask for a given symbol only once per shared library
event.  There won't be any harm in asking for the same symbol twice --
except for the possibility of getting into an infinite loop.


  reply	other threads:[~2001-04-26 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-17 16:29 Michael Snyder
2001-04-17 18:50 ` Jonathan Larmour
2001-04-19 13:40 ` Jim Blandy
2001-04-19 15:07   ` Michael Snyder
2001-04-21 16:35 ` Andrew Cagney
2001-04-26 14:22   ` Michael Snyder
2001-04-27  7:54     ` Andrew Cagney
2001-04-21 16:40 ` Andrew Cagney
2001-04-26 14:26   ` Michael Snyder [this message]
2001-04-27  8:20     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AE8928A.18E07030@cygnus.com \
    --to=msnyder@cygnus.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jtc@redback.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox