Re: [RFA] Add dependency of gdb on tcl/tk libraries

John R. Moore
2001-04-13T10:18:00Z

On Fri, 13 Apr 2001, Keith Seitz wrote:

> On Fri, 13 Apr 2001, Eli Zaretskii wrote:
>
> > > 2001-04-12 John R. Moore <jmoore@redhat.com>
> > >
> > > * configure.in: Added dependency of gdb on tcl/tk libraries.
> > > * Makefile.in: Likewise.
> > > * configure: Regenerated with the above using autoconf.
> >
> > Hmm... am I missing something, or does this patch _require_ tcl to be
> > linked in? What about ports that *never* build with tcl, such as
> > DJGPP? What if the Tcl and Tk directories don't exist at configure
> > time?
>
> This patch only really affects configure.in. The machinery for it has
> existed in gdb for over three years. You've been using it all along.
> (Spooky -- almost Erin Brokovich-ish.. Water, anyone?)
>
> The configury change that John is adding (which appears good) is confined
> only to Insight. A quick read of the surrounding code has:
>
> if test "${enable_gdbtk}" = "yes"; then
> [...]
> TCL_DEPS="${tcldir}${TCL_LIB_FILE}"
> [...]
> fi
>
> So, unless you configure with "--enable-gdbtk" or you have the insight
> module present (which enables "--enable-gdbtk" by default), you'll never
> see this.
>
> However, to be safe... John, have you/can you check out the gdb module
> (without Insight) and tried this? Does it cause any additional problems
> (TCL_DEPS, TK_DEPS, etc should all be blank).
>
> I have tested this patch with the insight module, both with
> --enable-gdbtk and without, and it works just fine in both cases.
>
> Keith
>
>

Yes, if one uses configure --disable-gdbtk then the following shows up in
the Makefile:

TCL =
TCL_CFLAGS =
TCL_DEPS =
GDBTKLIBS =
# Extra flags that the GDBTK files need:
GDBTK_CFLAGS =

# Where is the TK library? Typically in ../tk.
TK =
TK_CFLAGS =
TK_DEPS =

# Where is Itcl? Typically in ../itcl/itcl.
ITCL_CFLAGS =
ITCL =
ITCL_DEPS =

# Where is Itk? Typically in ../itcl/itk.
ITK_CFLAGS =
ITK =
ITK_DEPS =

# Where is Tix? Typically in ../tix.
TIX_CFLAGS =
TIX =
TIX_DEPS =

X11_CFLAGS =
X11_LDFLAGS =
X11_LIBS =

WIN32LDAPP =

-------------------------------------

What I haven't tested is if it works on cygwin (Windows).
The configury code mimics exactly what was done for
ITCL and ITK, so if those work, so should the new patch.

John