From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: gdb-patches@sources.redhat.com Subject: RFA: EINTR in procfs_wait Date: Tue, 10 Apr 2001 08:08:00 -0000 Message-id: <3AD32106.12A0443E@redhat.com> X-SW-Source: 2001-04/msg00099.html Folks, I got this patch and it seems that we did forget to test for EINTR in procfs_wait(). It looks like an "obvious fix" but I would like someone else to double check it. Thanks in advance. Fernando 2001-04-05 Adam Mirowski Fixed Insight on Solaris. It was not possible to debug a process because of EINTR "errors". * procfs.c: (procfs_wait): if proc_wait_for_stop() fails with EINTR, retry the call. Index: gdb/procfs.c ------- procfs.c ------- *** /tmp/dMKayx_ Tue Apr 10 16:20:54 2001 --- procfs.c Thu Apr 5 22:21:40 2001 *************** *** 3518,3531 **** --- 3518,3533 ---- if (retval != PIDGET (inferior_pid)) /* wrong child? */ error ("procfs: couldn't stop process %d: wait returned %d\n", inferior_pid, retval); /* FIXME: might I not just use waitpid? Or try find_procinfo to see if I know about this child? */ } + else if (errno == EINTR) + goto wait_again; else { /* Unknown error from wait_for_stop. */ proc_error (pi, "target_wait (wait_for_stop)", __LINE__); } } else