From: Michael Snyder <msnyder@cygnus.com>
To: Eirik Fuller <eirik@netapp.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: do_captured_thread_select
Date: Mon, 09 Apr 2001 11:21:00 -0000 [thread overview]
Message-ID: <3AD1FD8A.B2B197AB@cygnus.com> (raw)
In-Reply-To: <3AD17CE3.AA280B97@netapp.com>
Eirik Fuller wrote:
>
> This patch allows gdb's thread command to be used in macros. I've been
> using it since mid November with no problems (and I apologize for the
> delay in submitting it).
>
> --- gdb/thread.c- Wed Feb 2 20:14:36 2000
> +++ gdb/thread.c Thu Nov 16 20:31:42 2000
> @@ -663,7 +670,7 @@
> int num;
> struct thread_info *tp;
>
> - num = atoi ((char *)tidstr);
> + num = value_as_long(parse_and_eval(tidstr));
>
> tp = find_thread_id (num);
Can you explain the significance of change? Sorry if I'm being slow,
but I don't see it. What's the problem that you're fixing?
Also (not to be pedantic), we generally appreciate a ChangeLog entry
to accompany a patch.
Thanks,
Michael Snyder
next prev parent reply other threads:[~2001-04-09 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <39C17C60.3125D2C0@netapp.com>
[not found] ` <39C18CBC.1BC1F728@netapp.com>
[not found] ` <39D17683.FB3CA962@netapp.com>
[not found] ` <3A113B77.B50A60D7@cygnus.com>
[not found] ` <3A11D01C.7F0ADFCC@netapp.com>
[not found] ` <3A11FA7A.CCC941C3@cygnus.com>
[not found] ` <3A12022E.D96AB1EA@netapp.com>
[not found] ` <3A15C2E7.6EC92753@netapp.com>
2001-04-09 2:12 ` do_captured_thread_select Eirik Fuller
2001-04-09 11:21 ` Michael Snyder [this message]
[not found] ` <3AD245A5.1BEA8615@netapp.com>
2001-04-17 11:58 ` do_captured_thread_select Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AD1FD8A.B2B197AB@cygnus.com \
--to=msnyder@cygnus.com \
--cc=eirik@netapp.com \
--cc=gdb-patches@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox