From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: gdb-patches@sources.redhat.com Subject: RFA [infrun.c]: Add missing initialization for inferior_io_terminal Date: Fri, 06 Apr 2001 06:30:00 -0000 Message-id: <3ACDC414.C0C677B2@redhat.com> X-SW-Source: 2001-04/msg00056.html inferior_io_terminal is never initialized. Here is the patch. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9 Index: infcmd.c =================================================================== RCS file: /cvs/src/src/gdb/infcmd.c,v retrieving revision 1.26 diff -c -p -r1.26 infcmd.c *** infcmd.c 2001/03/27 20:36:23 1.26 --- infcmd.c 2001/04/06 13:27:18 *************** Register name as argument means describe *** 1966,1971 **** --- 1966,1972 ---- add_info ("float", float_info, "Print the status of the floating point unit\n"); + inferior_io_terminal = NULL; /* No inferior terminal specified (yet) */ set_inferior_args (xstrdup ("")); /* Initially no args */ inferior_environ = make_environ (); init_environ (inferior_environ); >From fnasser@redhat.com Fri Apr 06 07:18:00 2001 From: Fernando Nasser To: gdb-patches@sources.redhat.com Subject: RFA [arch-utils.c] Turn off unused PC bits in legacy_breakpoint_from_pc() Date: Fri, 06 Apr 2001 07:18:00 -0000 Message-id: <3ACDCF3D.90609740@redhat.com> X-SW-Source: 2001-04/msg00057.html Content-length: 1258 This is related to the ADDR_BITS_REMOVE() use have been talking about. This patch would not be immediately necessary, but it seems the right thing to do. We stay on the safe side and give a hint to someone who is implementing a gdbarch_breakpoint_from_pc() implementation. I met Andrew in the corridor sometime last week and we thought it would be a good idea. This is the patch that corresponds to what we have discussed. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9 Index: arch-utils.c =================================================================== RCS file: /cvs/src/src/gdb/arch-utils.c,v retrieving revision 1.23 diff -c -p -r1.23 arch-utils.c *** arch-utils.c 2001/03/27 20:36:23 1.23 --- arch-utils.c 2001/04/06 13:26:03 *************** *** 55,60 **** --- 55,63 ---- unsigned char * legacy_breakpoint_from_pc (CORE_ADDR * pcptr, int *lenptr) { + #ifdef ADDR_BITS_REMOVE + *pcptr = ADDR_BITS_REMOVE (*pcptr); + #endif /* {BIG_,LITTLE_}BREAKPOINT is the sequence of bytes we insert for a breakpoint. On some machines, breakpoints are handled by the target environment and we don't have to worry about them here. */ >From tromey@redhat.com Fri Apr 06 08:44:00 2001 From: Tom Tromey To: Eli Zaretskii Cc: deephan@erols.com, gdb-patches@sources.redhat.com Subject: Re: [PATCH] specify arguments to debugee from commandline (second try) Date: Fri, 06 Apr 2001 08:44:00 -0000 Message-id: <87vgoi58lr.fsf@creche.redhat.com> References: <20010330005457.A21793@llamedos.org> <20010330163603.A27435@llamedos.org> <20010403013600.B7630@llamedos.org> <87n19uirbk.fsf@creche.redhat.com> <200104060832.EAA17613@indy.delorie.com> X-SW-Source: 2001-04/msg00058.html Content-length: 741 >>>>> "Eli" == Eli Zaretskii writes: >> Likewise I'd like to be able to simply insert `gdb --run' into shell >> scripts or any other program-launching code to get the debugger to do >> the tedious work for me. Eli> Wouldn't such use get you in trouble in some cases anyway? The Eli> arguments you put after "gdb --run" are evaluated by the shell, Eli> so what GDB sees is not exactly what you typed. I'd imagine that Eli> in some cases this would produce subtle differences between "gdb Eli> --run" and issuing the `run' command inside GDB. I don't understand. Can you give an example? Maybe you mean that redirections won't work as expected. That's true. I agree that is something that should be addressed. Tom