From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Jeff Holcomb Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] monitor.c fix for rom68k target boards Date: Fri, 30 Mar 2001 12:58:00 -0000 Message-id: <3AC4F369.39725D8D@cygnus.com> References: X-SW-Source: 2001-03/msg00561.html Jeff Holcomb wrote: > > This patch allows gdb to work with rom68k target boards once again (it's > been broken for a year and a half apparently). > > I don't think the routine needs to care about checking for termination of > the string. In the case of this monitor, the SR is returned as > "2700-tfSm.111...xnzvc" for example. Before Jason's change to this > routine, it used strtoul which ended the matching at the first non > digit. Jason changed it to work with values larger than 'long' so it's > now a hand-coded loop to gather the digits. So the old code would just return with ``p'' pointing to one char beyond the hex digit? Andrew