Re: [RFA] Revised C++ ABI abstraction patches

Daniel Berlin
2001-03-15T19:12:00Z

Jim Blandy <jimb@zwingli.cygnus.com> writes:

> Andrew Cagney <ac131313@cygnus.com> writes:
> > When Dan originally submitted his original patch it was large.
> > Fortunatly it was only (mostly) the mechanical change of separating out
> > the C++ stuff (it was also approved so I don't know why it wasn't
> > committed). Now, however, the patch has managed to accumulate much much
> > more (sigh). This really should be broken down into the mechanical
> > change of creating a new file and the modifications that fix real bugs.
>
> I don't think this patch is really what you think it is. Perhaps it
> looks that way because of the way I wrote the ChangeLog entries. I
> was trying to preserve Dan's original log text, but I think if I just
> write a log entry from scratch, it will make a lot more sense. But do
> look at the actual patch, and I think you'll see what I mean.

I'll rewrite the changelog, i'm about to submit the 4th revision of
the patch, incorporating your fixes, my fixes, and my additions.

>
> Oh, there is one random fix in linespec.c that should be segregated.
> I'll fix that. But folks are acting as if it's some kind of horrible
> HP-style snowball, and that's not so.

It's funny, it actually removes most of the HP snowball.
--Dan