From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: "Frank Ch. Eigler" Cc: Will Cohen , gdb-patches@sources.redhat.com Subject: Re: Patch to provide m68k simulator to gdb Date: Fri, 09 Mar 2001 12:54:00 -0000 Message-id: <3AA63AB7.123C81FD@cygnus.com> References: <3A9C3128.A52307A@redhat.com> <3A9D2941.ECA95C7E@cygnus.com> <3AA40408.1A30B245@redhat.com> <3AA41929.7AD57C98@cygnus.com> <3AA50E7C.D8FF5E76@redhat.com> X-SW-Source: 2001-03/msg00150.html "Frank Ch. Eigler" wrote: > > Will Cohen writes: > > : [...] > : > If these are the register numbers being passed in via > : > sim_{fetch,store}_register() then they should be defined > : > include/sim-m68k.h. > : > : If that's the way to do it okay. I only saw include/sim-d10v.h there. > : None of the other simulators followed this approach. I was emulating > : what I saw in the vast majority of the simulators. > > FWIW, I agree with Will. The sim-d10v.h, while not a bad idea, is a > very lonely and rather old precedent to become required of new ports. FYI, That file was only introduced a year ago. It occured when the d10v was given an upgrade. I've been pretty consistent in asking anyone with a new simulator (merged or not) to follow that convention. Andrew