From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: jtc@redback.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA]: Remove unused header files. Date: Tue, 06 Mar 2001 15:06:00 -0000 Message-id: <3AA56CCA.E2095BCF@cygnus.com> References: <5mitltndwn.fsf@jtc.redback.com> <3AA2C971.D2432CEA@cygnus.com> <5mvgpm4mgx.fsf@jtc.redback.com> X-SW-Source: 2001-03/msg00127.html "J.T. Conklin" wrote: > > >>>>> "Andrew" == Andrew Cagney writes: > >> The decode_line_1() declaration (IMO) indicates a unclear separation > >> of interface and implementation. (Again, IMO) a function declaration > >> should only be in one header. Please share your thoughts, on this > >> specific case, and in general. decode_line_1() is the first of many > >> functions that have multiple declarations. > > Andrew> Only one? Just don't get me started on the number of extern > Andrew> declarations that appear in .c files! :-) Yes, I agree that > Andrew> function declarations should only appear once. > > Is this one of the things your static analysis database is checks for > (And can you send me a pointer to it again)? Static analysis database? You mean that big nasty (probably broken) awk script? http://sources.redhat.com/gdb/ari/ It checks it but doesn't list it (well not by default). Andrew