From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] More completion improvements Date: Sun, 18 Feb 2001 06:58:00 -0000 Message-id: <3A8FE260.217C0FB1@redhat.com> References: X-SW-Source: 2001-02/msg00336.html Eli Zaretskii wrote: > > People whose approval I'm seeking are: > > Fernando is listed as the maintainer of the rdi stuff. Chris is > responsible for win32-nat.c. I think solib.c and tracepoint.c are > Michael Snyder's. cli-cmds.c seems to be Fernando's again. I couldn't > identify who are the maintainers for the rest. > Eli, The distribution of maintainership per file breaks in certain cases. One example is the CLI that is still scattered around (I need to spend some more weekends collecting the pieces and moving them to gdb/cli). As long you only touch things that affect the CLI command syntax, command creation etc. without interfering with the actual implementation, I still can give you the approval. In the general case, it is always nice to see if the maintainer of the file has some objection though, as he/she may have a better idea of how something should be used or some other detail that requires a "field expert" opinion. This does not apply to your patch though. You are just giving extra information to the CLI so it can do a smarter completion. The exception would be the extra help lines you've added. They do conform to the CLI requirements (first line format), so they are OK with me. You're are Mr. Documentation :-), so I will not argue about the help text. They either add information that is already in the manual or that relate to the completion itself. I am approving it. IMHO this should be enough in the specific case of this patch. Thanks for the patch. Fernando P.S.: I debug Insight with the CLI (ironic, isn't it? -- but just imagine two sets of windows for the "top-gdb" and for the "inferior" gdb), and I am a completion addict, so I am eager to use the improvements. -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9