From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fernando Nasser To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.c++/inherit.change: accommodate v3 abi formatting Date: Sat, 17 Feb 2001 14:24:00 -0000 Message-id: <3A8EF9A1.2B0D8264@redhat.com> References: <200102172044.MAA27647@bosch.cygnus.com> X-SW-Source: 2001-02/msg00328.html Michael Elizabeth Chastain wrote: > > This is Sunday Project patch #3. > > This patch fixes testsuite/gdb.base/inherit.exp to work with either g++ > demanglers: v2 and v3. Unlike my previous monster C++ testsuite patches, > this one is bite size. > > The problem in inherit.exp is two 'runto foo(void)' statements that > are used to control execution. They work just fine when converted to > 'runto foo'. The names used are not overloaded or anything; they are > just ordinary marker names. > > This fixes 55 FAILs. After applying this patch, there are still 7 > FAILs, but these look like actual issues in g++ and/or gdb rather than > the test script. > > I tested this with v2 and v3 versions of g++ on Red Hat Linux 7 native > and Solaris 2.6 native. > > OK to apply? > Sure. Thanks. Fernando > Michael Elizabeth Chastain > > "love without fear" > > 2001-02-14 Michael Chastain > > * gdb.c++/inherit.exp (do_tests): Change runto statements > from "runto 'foo(void)'" to "runto 'foo'". This makes the > statements demangler agnostic. > > Index: gdb/testsuite/gdb.c++/inherit.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.c++/inherit.exp,v > retrieving revision 1.1.1.4 > diff -c -3 -p -r1.1.1.4 inherit.exp > *** gdb/testsuite/gdb.c++/inherit.exp 1999/12/07 03:56:17 1.1.1.4 > --- gdb/testsuite/gdb.c++/inherit.exp 2001/02/15 01:23:58 > *************** > *** 1,4 **** > ! # Copyright (C) 1992, 1993, 1994, 1997, 1999 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > --- 1,4 ---- > ! # Copyright (C) 1992, 1993, 1994, 1997, 1999, 2001 Free Software Foundation, Inc. > > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > *************** proc do_tests {} { > *** 1012,1018 **** > > gdb_stop_suppressing_tests; > > ! if { ![ runto 'inheritance2(void)' ] } { > gdb_suppress_tests; > } > > --- 1012,1018 ---- > > gdb_stop_suppressing_tests; > > ! if { ![ runto 'inheritance2' ] } { > gdb_suppress_tests; > } > > *************** proc do_tests {} { > *** 1024,1030 **** > > gdb_stop_suppressing_tests; > > ! if { ![ runto 'inheritance4(void)' ] } { > gdb_suppress_tests; > } > > --- 1024,1030 ---- > > gdb_stop_suppressing_tests; > > ! if { ![ runto 'inheritance4' ] } { > gdb_suppress_tests; > } > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9