From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Snyder To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] testsuite/gdb.c++/cplusfuncs.{exp,cc}: work with either g++ demangler Date: Mon, 12 Feb 2001 12:12:00 -0000 Message-id: <3A8843E0.F92E0B04@cygnus.com> References: <200102112349.PAA20280@bosch.cygnus.com> X-SW-Source: 2001-02/msg00174.html Michael Elizabeth Chastain wrote: > > This is Sunday Sourceware patch #2, revision 2. > > Changes since revision 1: > - Change wording of ChangeLog with respect to gdb/19. > - Change one more "char *" to "$dm_type_char_star". > > gdb has two g++ demanglers. Currently, this test script works okay on > the v2 demangler, but gives 83 FAILs with the v3 demangler. This patch > enhances testsuite/gdb.c++/cplusfuncs.{cc,exp} to work with either > demangler. > > The bulk of the change is handling formatting differences: > > old demangler new demangler > --- --------- --- --------- > "operator, " "operator," > "char *" "char*" > "int *" "int*" > "long *" "long*" > "void *" "void*" > "foo &" "foo&" > "unsigned int" "unsigned" > "void" "" Michael, I'm curious why you didn't simply write separate regular expressions, one to recognize the new demangler style and one to recognize the old, rather than add all this new mechanics. I'm concerned about the tcl scripts becoming complicated and difficult to maintain. Please don't get me wrong -- I very much appreciate both the work that you're investing and the fact that you're championing this cause.