From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>
Subject: [committed][gdb/testsuite] Fix gdb.btrace/reconnect.exp with native-gdbserver
Date: Tue, 23 Apr 2019 13:51:00 -0000 [thread overview]
Message-ID: <39db12c4-8c92-772e-2666-da381eeebe57@suse.de> (raw)
In-Reply-To: <20190418214700.GA10515@delia>
Committed as obvious.
Thanks,
- Tom
On 18-04-19 23:47, Tom de Vries wrote:
> Hi,
>
> When running gdb.btrace/reconnect.exp with native-gdbserver, we run into:
> ...
> FAIL: gdb.btrace/reconnect.exp: first: stepi 19
> ...
> due to the fact that we're trying to match:
> ...
> stepi 19^M
> 0x00007ffff7dd8b57 in _dl_start () from /lib64/ld-linux-x86-64.so.2^M
> ...
> using pattern:
> ...
> gdb_test "stepi 19" "0x.* in .* from target.*"
> ...
>
> Fix this by changing the pattern to:
> ...
> gdb_test "stepi 19" "0x.* in .* from .*"
> ...
>
> Tested on x86_64-linux with native and native-gdbserver.
>
> OK for trunk?
>
> Thanks,
> - Tom
>
> [gdb/testsuite] Fix gdb.btrace/reconnect.exp with native-gdbserver
>
> gdb/testsuite/ChangeLog:
>
> 2019-04-18 Tom de Vries <tdevries@suse.de>
>
> PR gdb/24433
> * gdb.btrace/reconnect.exp: Fix stepi 19 pattern.
>
> ---
> gdb/testsuite/gdb.btrace/reconnect.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp
> index c4b41fc1bd..e791657e7a 100644
> --- a/gdb/testsuite/gdb.btrace/reconnect.exp
> +++ b/gdb/testsuite/gdb.btrace/reconnect.exp
> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
> # Create a record, check, reconnect
> with_test_prefix "first" {
> gdb_test_no_output "record btrace" "record btrace enable"
> - gdb_test "stepi 19" "0x.* in .* from target.*"
> + gdb_test "stepi 19" "0x.* in .* from .*"
>
> gdb_test "info record" [multi_line \
> "Active record target: .*" \
>
prev parent reply other threads:[~2019-04-23 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 21:47 [PATCH][gdb/testsuite] " Tom de Vries
2019-04-23 13:51 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39db12c4-8c92-772e-2666-da381eeebe57@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox