From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33376 invoked by alias); 3 Jan 2020 13:11:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33368 invoked by uid 89); 3 Jan 2020 13:11:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-13.7 required=5.0 tests=AWL,BAYES_00,EXECUTABLE_URI,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_EXEURI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=rva, HX-Spam-Relays-External:CriticalPath, H*RU:CriticalPath, HAuthentication-Results:smtp.auth X-HELO: sa-prd-fep-044.btinternet.com Received: from mailomta29-sa.btinternet.com (HELO sa-prd-fep-044.btinternet.com) (213.120.69.35) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jan 2020 13:11:49 +0000 Received: from sa-prd-rgout-001.btmx-prd.synchronoss.net ([10.2.38.4]) by sa-prd-fep-044.btinternet.com with ESMTP id <20200103131147.JAKT8432.sa-prd-fep-044.btinternet.com@sa-prd-rgout-001.btmx-prd.synchronoss.net>; Fri, 3 Jan 2020 13:11:47 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-OWM-Source-IP: 31.51.207.12 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean Received: from [192.168.1.106] (31.51.207.12) by sa-prd-rgout-001.btmx-prd.synchronoss.net (5.8.337) (authenticated as jonturney@btinternet.com) id 5DF93CE102B5A897; Fri, 3 Jan 2020 13:11:47 +0000 Subject: Re: [PATCH] Fix a crash with a malformed PE header To: gdb-patches@sourceware.org References: <20200102125405.11499-1-jon.turney@dronecode.org.uk> <835zhuj71c.fsf@gnu.org> Cc: Eli Zaretskii From: Jon Turney Message-ID: <39b8efed-e23e-db20-4b28-332ceda2d8df@dronecode.org.uk> Date: Fri, 03 Jan 2020 13:11:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <835zhuj71c.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------F9E35AF6CAB6A23D515FBDA8" X-SW-Source: 2020-01/txt/msg00036.txt.bz2 This is a multi-part message in MIME format. --------------F9E35AF6CAB6A23D515FBDA8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 659 On 02/01/2020 13:56, Eli Zaretskii wrote: >> From: Jon Turney >> Cc: Jon Turney >> Date: Thu, 2 Jan 2020 12:54:05 +0000 >> >> --- a/gdb/coff-pe-read.c >> +++ b/gdb/coff-pe-read.c >> @@ -441,6 +441,12 @@ read_pe_exported_syms (minimal_symbol_reader &reader, >> } >> } >> >> + if (expptr == 0) >> + { >> + /* no section contains export table rva */ >> + return; >> + } >> + > > Thanks. Would it make sense to produce some diagnostic output here, > when an appropriate debug-FOO option is set? Yes, I suppose that's better than just a comment. How about the attached? --------------F9E35AF6CAB6A23D515FBDA8 Content-Type: text/plain; charset=UTF-8; name="0001-Fix-a-crash-with-a-malformed-PE-header.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Fix-a-crash-with-a-malformed-PE-header.patch" Content-length: 1806 RnJvbSBiNzhlZTU3MzZkOTNkN2ZhMzQ3NmE2OWNjMTEyMjljMDQ3ZjQ3N2Vj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxq b24udHVybmV5QGRyb25lY29kZS5vcmcudWs+CkRhdGU6IFRodSwgMiBKYW4g MjAyMCAwMDoyNTo1NiArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBhIGNy YXNoIHdpdGggYSBtYWxmb3JtZWQgUEUgaGVhZGVyCgpEb24ndCB0cnkgdG8g cmVhZCB0aGUgUEUgZXhwb3J0IHRhYmxlIHdoZW4gbm8gc2VjdGlvbiBjb250 YWlucyB0aGUgUlZBCmZvciBpdC4KCihJIGhhdmUgYSBQRSBleGVjdXRhYmxl IFsxXSBwYWNrZWQgd2l0aCBVUFgsIHdoZXJlIHRoZSBleHBvcnQgdGFibGUg ZGF0YQpkaXJlY3RvcnkgZW50cnkgY29udGFpbnMgYSBSVkEgd2hpY2ggZG9l c24ndCBjb3JyZXNwb25kIHRvIGFueSBzZWN0aW9uLgpNaXN0YWtlbmx5IHRy eWluZyB0byBkZWJ1ZyB0aGlzIHdpdGggZ2RiIG1ha2VzIGl0IGNyYXNoLikK ClsxXSBodHRwczovL2N5Z3dpbi5jb20vc2V0dXAvc2V0dXAtMi44OTgueDg2 XzY0LmV4ZQoKMjAyMC0wMS0wMiAgSm9uIFR1cm5leSAgPGpvbi50dXJuZXlA ZHJvbmVjb2RlLm9yZy51az4KCgkqIGNvZmYtcGUtcmVhZC5jIChyZWFkX3Bl X2V4cG9ydGVkX3N5bXMpOiBEb24ndCB0cnkgdG8gcmVhZCB0aGUKCWV4cG9y dCB0YWJsZSBpZiBubyBzZWN0aW9uIGNvbnRhaW5zIGl0J3MgUlZBLgotLS0K IGdkYi9DaGFuZ2VMb2cgICAgICB8IDUgKysrKysKIGdkYi9jb2ZmLXBlLXJl YWQuYyB8IDkgKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9nZGIvY29mZi1wZS1yZWFkLmMgYi9n ZGIvY29mZi1wZS1yZWFkLmMKaW5kZXggYjA1MzU3YmI4Yi4uOTI2ZGI1N2U1 OCAxMDA2NDQKLS0tIGEvZ2RiL2NvZmYtcGUtcmVhZC5jCisrKyBiL2dkYi9j b2ZmLXBlLXJlYWQuYwpAQCAtNDQxLDYgKzQ0MSwxNSBAQCByZWFkX3BlX2V4 cG9ydGVkX3N5bXMgKG1pbmltYWxfc3ltYm9sX3JlYWRlciAmcmVhZGVyLAog CX0KICAgICB9CiAKKyAgaWYgKGV4cHB0ciA9PSAwKQorICAgIHsKKyAgICAg IGlmIChkZWJ1Z19jb2ZmX3BlX3JlYWQpCisJZnByaW50Zl91bmZpbHRlcmVk IChnZGJfc3RkbG9nLCBfKCJObyBzZWN0aW9uIGNvbnRhaW5zIGV4cG9ydCBS VkEgZm9yICIKKwkJCQkJICAiZGxsIFwiJXNcIlxuIiksCisJCQkgICAgZGxs X25hbWUpOworICAgICAgcmV0dXJuOworICAgIH0KKwogICBleHBvcnRfcnZh ID0gZXhwb3J0X29wdGhkcnJ2YTsKICAgZXhwb3J0X3NpemUgPSBleHBvcnRf b3B0aGRyc2l6ZTsKIAotLSAKMi4yMS4wCgo= --------------F9E35AF6CAB6A23D515FBDA8--