From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39490 invoked by alias); 18 Oct 2017 17:33:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38688 invoked by uid 89); 18 Oct 2017 17:33:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=helped X-HELO: smtprelay.synopsys.com Received: from smtprelay4.synopsys.com (HELO smtprelay.synopsys.com) (198.182.47.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 17:33:18 +0000 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id BCDD724E0A35; Wed, 18 Oct 2017 10:33:16 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id A53698D6; Wed, 18 Oct 2017 10:33:16 -0700 (PDT) Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) by mailhost.synopsys.com (Postfix) with ESMTP id 865A28D2; Wed, 18 Oct 2017 10:33:16 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.266.1; Wed, 18 Oct 2017 10:33:16 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Wed, 18 Oct 2017 19:33:13 +0200 From: Anton Kolesov To: Yao Qi CC: "gdb-patches@sourceware.org" , Francois Bedard Subject: RE: [PATCH 1/3] arc: Add XML target descriptions for Linux targets Date: Wed, 18 Oct 2017 17:33:00 -0000 Deferred-Delivery: Wed, 18 Oct 2017 17:32:59 +0000 Message-ID: <39A54937CC95F24AA2F794E2D2B66B135895D7C6@DE02WEMBXB.internal.synopsys.com> References: <20171011145633.19343-1-Anton.Kolesov@synopsys.com> <20171012012859.GJ8425@1170ee0b50d5> In-Reply-To: <20171012012859.GJ8425@1170ee0b50d5> x-dg-ref: =?utf-8?B?UEcxbGRHRStQR0YwSUc1dFBTSmliMlI1TG5SNGRDSWdjRDBpWXpwY2RYTmxj?= =?utf-8?B?bk5jWVd0dmJHVnpiM1l1YzNsdWIzQnplWE5jWVhCd1pHRjBZVnh5YjJGdGFX?= =?utf-8?B?NW5YREE1WkRnME9XSTJMVE15WkRNdE5HRTBNQzA0TldWbExUWmlPRFJpWVRJ?= =?utf-8?B?NVpUTTFZbHh0YzJkelhHMXpaeTB4WVRJeFpHWXlOaTFpTkRKaExURXhaVGN0?= =?utf-8?B?WVRneU5pMDBPRFV4WWpjM1pUbGhPVFZjWVcxbExYUmxjM1JjTVdFeU1XUm1N?= =?utf-8?B?amN0WWpReVlTMHhNV1UzTFdFNE1qWXRORGcxTVdJM04yVTVZVGsxWW05a2VT?= =?utf-8?B?NTBlSFFpSUhONlBTSTBNVGc0SWlCMFBTSXhNekUxTWpneU1UUTFPVEF6TnpF?= =?utf-8?B?eU16a2lJR2c5SWpac2JXbERUMnNyT1dvdmN6bGlNMFEwVFhKb1FXeEJVR2xJ?= =?utf-8?B?YnowaUlHbGtQU0lpSUdKc1BTSXdJaUJpYnowaU1TSWdZMms5SW1OQlFVRkJS?= =?utf-8?B?VkpJVlRGU1UxSlZSazVEWjFWQlFVSlJTa0ZCUTI1MFdtNWpUbXRxVkVGUk9W?= =?utf-8?B?cFhWWGRpVG1aMlJVUXhiRnBVUW5NeEt6aFJUMEZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRklRVUZCUVVOclEwRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGRlFVRlJRVUpCUVVGQlptWlBTRFZSUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJTalJCUVVGQ2JVRkhhMEZpWjBKb1FVYzBRVmwzUW14QlJq?= =?utf-8?B?aEJZMEZDYzBGSFJVRmlaMEoxUVVkclFXSm5RbTVCUmpoQlpIZENhRUZJVVVG?= =?utf-8?B?YVVVSjVRVWN3UVZsUlFubEJSM05CUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVW?= =?utf-8?B?QlFVRkJRVUZCUVVGQlowRkJRVUZCUVc1blFVRkJSMWxCWW5kQ01VRkhORUZh?= =?utf-8?B?UVVKNVFVaHJRVmgzUW5kQlIwVkJZMmRDTUVGSE5FRmFVVUo1UVVoTlFWaDNR?= =?utf-8?B?bTVCUjFsQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRlJRVUZCUVVGQlFVRkJRMEZCUVVGQlFVTmxRVUZCUVZwblFu?= =?utf-8?B?WkJTRlZCWW1kQ2EwRklTVUZsVVVKbVFVaEJRVmxSUW5sQlNGRkJZbWRDYkVG?= =?utf-8?B?SVNVRmpkMEptUVVoTlFWbFJRblJCU0UxQlpGRkNkVUZIWTBGWWQwSnFRVWM0?= =?utf-8?B?UVdKblFtMUJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZDUVVGQlFVRkJRVUZCUVVsQlFVRkJRVUZL?= =?utf-8?B?TkVGQlFVSnRRVWM0UVdSUlFuVkJSMUZCWTJkQ05VRkdPRUZqUVVKb1FVaEpR?= =?utf-8?B?V1JCUW5WQlIxVkJZMmRDZWtGR09FRmpkMEpvUVVjd1FXTjNRakZCUnpSQldu?= =?utf-8?B?ZENaa0ZJU1VGYVVVSjZRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlJVRkJRVUZCUVVGQlFV?= =?utf-8?B?Rm5RVUZCUVVGQmJtZEJRVUZIV1VGaWQwSXhRVWMwUVZwQlFubEJTR3RCV0hk?= =?utf-8?B?Q2QwRkhSVUZqWjBJd1FVYzBRVnBSUW5sQlNFMUJXSGRDZWtGSE1FRmhVVUpx?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVkZC?= =?utf-8?B?UVVGQlFVRkJRVUZEUVVGQlFVRkJRMlZCUVVGQldtZENka0ZJVlVGaVowSnJR?= =?utf-8?B?VWhKUVdWUlFtWkJTRUZCV1ZGQ2VVRklVVUZpWjBKc1FVaEpRV04zUW1aQlNF?= =?utf-8?B?MUJaRUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVKQlFVRkJRVUZCUVVGQlNVRkJRVUZCUVVvMFFVRkJRbTFCUnpo?= =?utf-8?B?QlpGRkNkVUZIVVVGalowSTFRVVk0UVdOQlFtaEJTRWxCWkVGQ2RVRkhWVUZq?= =?utf-8?B?WjBKNlFVWTRRV1JCUW5wQlJ6QkJXWGRCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkZRVUZCUVVGQlFVRkJRV2RCUVVGQlFVRnVa?= =?utf-8?B?MEZCUVVkWlFXSjNRakZCUnpSQldrRkNlVUZJYTBGWWQwSjNRVWRGUVdOblFq?= =?utf-8?B?QkJSelJCV2xGQ2VVRklUVUZZZDBJeFFVY3dRVmwzUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCVVVGQlFVRkJRVUZCUVVO?= =?utf-8?B?QlFVRkJRVUZEWlVGQlFVRmFkMEl3UVVoTlFWaDNRbmRCU0VsQlluZENhMEZJ?= =?utf-8?B?VlVGWmQwSXdRVVk0UVdSQlFubEJSMFZCWVZGQ2RVRkhhMEZpWjBKdVFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFrRkJR?= =?utf-8?B?VUZCUVVGQlFVRkpRVUZCUVVGQlNqUkJRVUZDZWtGSFJVRmlRVUpzUVVoTlFW?= =?utf-8?B?aDNRbWhCUjAxQldYZENka0ZJVlVGaVowSXdRVVk0UVdOQlFuTkJSMFZCWW1k?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVVZCUVVGQlFVRkJRVUZCWjBGQlFVRkJRVzVuUVVGQlNFMUJXVkZD?= =?utf-8?B?YzBGSFZVRmpkMEptUVVoRlFXUlJRblpCU0ZGQldsRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGUlFVRkJRVUZCUVVGQlEwRkJRVUZCUVVObFFV?= =?utf-8?B?RkJRV04zUW5WQlNFRkJZM2RDWmtGSGQwRmhVVUpxUVVkVlFXSm5RbnBCUjFW?= =?utf-8?B?QldIZENhRUZJVlVGa1FVSnZRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkNRVUZCUVVGQlFVRkJRVWxC?= =?utf-8?B?UVVGQlFVRktORUZCUVVKNlFVYzBRV05CUW5wQlJqaEJZa0ZDY0VGSFRVRmFV?= =?utf-8?B?VUoxUVVoTlFWcFJRbVpCU0UxQlpFRkNhRUZJU1VGa1FVSm1RVWRSUVZsUlFq?= =?utf-8?B?QkJSMVZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUlVGQlFV?= =?utf-8?B?RkJRVUZCUVVGblFVRkJRVUZCYm1kQlFVRklUVUZpWjBKM1FVaE5RVmgzUW5O?= =?utf-8?B?QlIydEJXWGRDYkVGSE5FRmpkMEpzUVVZNFFXUkJRbXhCU0VsQllsRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQT0iLz48L21ldGE+?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2017-10/txt/msg00571.txt.bz2 SGkgWWFvLA0KDQooVGhpcyBpcyBhIHJpZ2h0IGVtYWlsIHRoaXMgdGltZSku DQoNCj4gDQo+ID4gTGludXggZGVzY3JpcHRpb25zOg0KPiA+DQo+ID4gLSBF eHBsaWNpdGx5IHNwZWNpZnkgQ1BVIG1hY2hpbmUuDQo+ID4gLSBSZW1vdmUg YmFyZW1ldGFsIG9ubHkgSUxJTkt7LDEsMn0gcmVnaXN0ZXJzLg0KPiA+IC0g QWRkIExQX1NUQVJUIGFuZCBMUF9FTkQgcmVnaXN0ZXJzIGZvciBoYXJkd2Fy ZSBsb29wcyAtIHJlcXVpcmVkIHRvDQo+IHByb3Blcmx5DQo+ID4gICBldmFs dWF0ZSBwb3NzaWJsZSBuZXh0IGluc3RydWN0aW9uIGR1cmluZyBzb2Z0d2Fy ZSBzaW5nbGUgaW5zdHJ1Y3Rpb24NCj4gPiAgIHN0ZXBwaW5nLg0KPiA+IC0g QWRkIEJUQSByZWdpc3RlciB3aGljaCBjb250YWlucyBicmFuY2ggdGFyZ2V0 IGFkZHJlc3MgLSBhZGRyZXNzIG9mIG5leHQNCj4gPiAgIGluc3RydWN0aW9u IHdoZW4gcHJvY2Vzc29yIGlzIGluIHRoZSBkZWxheSBzbG90Lg0KPiA+IC0g QVJDIEhTIGRlc2NyaXB0aW9uIGFsc28gYWRkcyBSMzAsIFI1OCBhbmQgUjU5 IHJlZ2lzdGVycywgc3BlY2lmaWMgdG8gdGhpcw0KPiA+ICAgYXJjaGl0ZWN0 dXJlLg0KPiANCj4gSU1PLCBpdCBpcyBub3QgYSBnb29kIHByYWN0aXNlIHRv IGxpbnV4IGFuZCBub24tbGludXggdGFyZ2V0IGRlc2NyaXB0aW9ucyBoYXZl DQo+IHRhcmdldCBmZWF0dXJlcyBvZiB0aGUgc2FtZSBuYW1lLCBidXQgc2Ft ZSB0YXJnZXQgZmVhdHVyZXMgaGF2ZSB0cml2aWFsDQo+IGRpZmZlcmVuY2Vz LCBhcyB5b3UgZGVzY3JpYmVkIGFib3ZlLiAgVGhlIGNvbW1vbiBwcmFjdGlz ZSB3ZSBkaWQgaXMgdG8NCj4gZGVmaW5lIGVhY2ggdGFyZ2V0IGZlYXR1cmUg eG1sIGZpbGUsIGFuZCB1c2UgeGk6aW5jbHVkZSB0byAiaW5jbHVkZSINCj4g ZWFjaCB0YXJnZXQgZmVhdHVyZSBpbnRvIHRhcmdldCBkZXNjcmlwdGlvbi4g IEFsbCBleGlzdGluZyB0YXJnZXQgZGVzY3JpcHRpb25zDQo+IGZvbGxvdyB0 aGlzIGFwcHJvYWNoLg0KPiANCg0KSWYgSSBleHRyYWN0IFI1OCwgUjU5IGFu ZCBJTElOSy9SMjkgaW50byBzZXBhcmF0ZSBmZWF0dXJlcyB0aGF0IHdvdWxk IGNyZWF0ZQ0KbXVsdGlwbGUgcHJvYmxlbXM6DQoNCi0gb3JkZXIgb2YgcmVn aXN0ZXJzIGluICJpbmZvIHJlZ2lzdGVycyIgd2lsbCBub3QgbWF0Y2ggYXJj aGl0ZWN0dXJhbCBudW1iZXJzDQogIG9mIHJlZ2lzdGVycy4NCi0gdGhhdCB3 b3VsZCBhZGQgdHdvIFhNTCBmZWF0dXJlcyBiZWNhdXNlIG9mIGp1c3QgdGhy ZWUgcmVnaXN0ZXJzLiBDb25zaWRlcmluZw0KICBhbW91bnQgb2YgY29kZSB0 aGF0IGlzIG5lZWRlZCBpbiAqLXRkZXAuYyBmaWxlcyBmb3IgZWFjaCBmZWF0 dXJlIGl0DQogIGRvZXNuJ3QgbG9vayBsaWtlIGEgZ29vZCB0cmFkZSBvZmYu IEVzcGVjaWFsbHkgc2luY2UgdGhpcyBzaG91bGQgYmUNCiAgcHJvcGFnYXRl ZCB0byBlYWNoIGFuZCBldmVyeSBSU1Atc2VydmVyIHRoYXQgd29ya3Mgd2l0 aCBBUkMsIHNvIHRoYXQgdGhleSB3aWxsDQogIHByb2R1Y2UgWE1MIHRhcmdl dCBkZXNjcmlwdGlvbnMgdGhhdCBtYXRjaGVzIEdEQiBleHBlY3RhdGlvbnMg LSBhbG1vc3QgYWxsIG9mDQogIHRoZW0gZ2VuZXJhdGUgZGVzY3JpcHRpb25z IGJhc2VkIG9uIHdoYXQgYXJlIHRoZSBhY3R1YWwgcmVnaXN0ZXJzIGluIHRo ZQ0KICB0YXJnZXQgQ1BVIC0gUlNQLXNlcnZlciBpbiBHREIgaXMgdGhlIG9u bHkgb25lIHRoYXQgdXNlcyBmaWxlcyBmcm9tDQogIGdkYi9mZWF0dXJlcy8u IFNvIGFkZGluZyBuZXcgZmVhdHVyZXMgdG8gbWFrZSBzdXJlIHRoYXQgZWFj aCBmZWF0dXJlIGlzIGZpeGVkDQogIGluIGl0cyBjb250ZW50IHdpbGwgYWRk IGEgbG90IG9mIGNvZGUgb3ZlcmFsbCwgYnV0IEnigJltIG5vdCBzdXJlIHdo YXQgd291bGQgYmUNCiAgYW4gYWR2YW50YWdlIG9mIHRoaXMuIEdEQiBhY2Nl cHRzIGFyYml0cmFyeSBYTUwgZmVhdHVyZXMsIGJ1dCBleHBsaWNpdA0KICBD KystY29kZSBzdGlsbCBzaG91bGQgYmUgd3JpdHRlbiBmb3IgYW4gWE1MIGZl YXR1cmUgaWYgdGhlcmUgaXMgYSBuZWVkIGZvcg0KICBhbHRlcm5hdGl2ZSBu YW1lcyBvciBhIHNwZWNpZmljIGludGVybmFsIG51bWJlciBmb3IgYSByZWdp c3Rlci4NCi0gYW5kIHRoaW5ncyBnZXQgd29yc2UgaWYgd2UgY29uc2lkZXIg b3RoZXIgb3B0aW9uYWwgcmVnaXN0ZXJzIGluIEFSQzogdGhlcmUNCiAgYXJl IGV4dGVuc2lvbiBjb3JlIHJlZ2lzdGVycyBSMzItUjU3IHRoYXQgY2FuIGJl IGFkZGVkIGJ5IGhhcmR3YXJlIGRlc2lnbmVyczsNCiAgdGhlcmUgaXMgYSAi cmVkdWNlZCByZWdpc3RlciBmaWxlIiBjb25maWd1cmF0aW9uIHdoZXJlIG1h bnkgY29yZSByZWdpc3RlcnMNCiAgYXJlIHJlbW92ZWQsIGJ1dCB0aGVyZSBh cmUgdHdvIGdyb3VwcyBvZiByZWdpc3RlcnMgcmVtb3ZlZCwgc28gZXh0cmFj dGluZw0KICB0aGVtIGludG8gc2VwYXJhdGUgZmVhdHVyZXMgd291bGQgYWxz byBicmVhayBvcmRlciBvZiByZWdpc3RlciAoUjQgd2lsbCBiZQ0KICBhZnRl ciBSMzEsIGV0YykuDQoNClRoYXQncyB3aHkgaW4gdGhlIHBhc3QgSSd2ZSBk ZWNpZGVkIHRoYXQgaXQgaXMgYmV0dGVyIHRvIGhhdmUgZmV3IGZlYXR1cmVz LCBidXQNCmFsbG93IGNvbnRlbnQgb2YgZmVhdHVyZXMgdG8gYmUgZmxleGli bGUgLSB0aGF0IGFsbG93cyBmb3Igc2ltcGxlDQppbXBsZW1lbnRhdGlvbiBp biBHREIsIFJTUC1zZXJ2ZXJzIGFuZCBhbHNvIGhlbHBlZCB3aXRoIHRyYW5z aXRpb24gZnJvbSB0aGUNCnByZS1YTUwgdGFyZ2V0IGRlc2NyaXB0aW9ucyBz eXN0ZW0gdGhhdCB3YXMgdXNlZCBpbiBHREIgZm9yayBmb3IgQVJDLiAgQ3Jl YXRpbmcNCnN0cmljdCBmZWF0dXJlcyBmb3IgQVJDIGJhc2VsaW5lIHJlZ2lz dGVycyBhbHdheXMgbG9va2VkIHRvIG1lIHVzIGEgZmVhc2libGUsDQpidXQg YW4gdW5uZWNlc3NhcmlseSBjb21wbGV4IHRhc2sgd2l0aG91dCBjbGVhciBi ZW5lZml0LiAgTWFueSBvZiBBUkMgcmVnaXN0ZXJzDQoobm90IG1lbnRpb25l ZCBpbiBHREIgYW55d2hlcmUpIGNhbiBiZSBncm91cGVkIGludG8gZmVhdHVy ZXMgc3VjY2Vzc2Z1bGx5LCBidXQNCnRoZSBjb3JlIHJlZ2lzdGVyIHNldCBk b2Vzbid0IG1hcCB3ZWxsIGludG8gWE1MIGZlYXR1cmVzLCBJIHRoaW5rLCBi ZWNhdXNlDQp0aGVyZSBpcyBzbyBtdWNoIG9mIGludGVybWl4IGJldHdlZW4g b3B0aW9uYWwgYW5kIG5vbi1vcHRpb25hbCByZWdpc3RlcnMuDQpUaGluZ3Mg d291bGQgYmUgZWFzaWVyIGlmIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGlu Y2x1ZGUgYW5vdGhlciBYTUwgZmlsZQ0Kd2l0aG91dCBoYXZpbmcgYSBzZXBh cmF0ZSBmZWF0dXJlIGluIHRoYXQgZmlsZS4NCg0KV2hhdCwgSSB0aGluaywg SSBjYW4gZG8gaXMgdG8gZGVzaWduYXRlIGEgc2VwYXJhdGUgWE1MIGZlYXR1 cmUgZm9yIExpbnV4LCBzbw0KdGhhdCB0aGUgY29udGVudCB3aWxsIG5vdCBj bGFzaCB3aXRoIGEgZ2VuZXJpYyAiY29yZS5hcmN2MiIgZmVhdHVyZS4gIExp c3Qgb2YNCnJlZ2lzdGVycyBhdmFpbGFibGUgb24gTGludXggaXMgZmFpcmx5 IGNlcnRhaW4gYW5kIGZpeGVkLCBiZWNhdXNlIGl0IGRlcGVuZHMgb24NCkxp bnV4IHJhdGhlciB0aGFuIG9uIGhhcmR3YXJlIGFuZCBvdXIgTGludXggcG9y dCBzdXBwb3J0IG9ubHkgY2VydGFpbiBDUFUNCmNvbmZpZ3VyYXRpb24uIFBs dXMgdGhlcmUgaXMgb25seSBvbmUgR0RCc2VydmVyIGZvciBMaW51eCB0YXJn ZXRzIGFuZCBpdCBpcyBhDQpwYXJ0IG9mIEdEQiBpdHNlbGYuIEhvd2V2ZXIg dGhhdCB3b3VsZCBiZSBhIHNpbmdsZSBmZWF0dXJlLCBzbyBpdCBzdGlsbCB3 aWxsDQpub3QgYmUgYWJsZSB0byBpbmNsdWRlIHJlZ2lzdGVycyB3cml0dGVu IGluIG90aGVyIHhtbCBmaWxlcy4gQnV0IGZvciBiYXJlbWV0YWwNCkknZCBw cmVmZXIgdG8ga2VlcCB0aGUgY3VycmVudCBYTUwgZmVhdHVyZXMgdGhhdCBh bGxvdyBmb3Igc2VtaS1hcmJpdHJhcnkgbGlzdA0Kb2YgcmVnaXN0ZXJzLCBl c3BlY2lhbGx5IHNpbmNlIEkgbmVlZCB0byBtYWludGFpbiBjb21wYXRpYmls aXR5IHdpdGggZXhpc3RpbmcNClJTUC1zZXJ2ZXJzLg0KDQpBbnRvbg0KDQo= >From gdb-patches-return-142765-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Oct 18 18:29:01 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 48238 invoked by alias); 18 Oct 2017 18:29:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48002 invoked by uid 89); 18 Oct 2017 18:29:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=shake, super X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 18:28:59 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AEA7DC04AC4F for ; Wed, 18 Oct 2017 18:28:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AEA7DC04AC4F Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths@redhat.com Received: from valrhona.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BE536F11A for ; Wed, 18 Oct 2017 18:28:58 +0000 (UTC) Subject: Re: [PATCH] Canonicalize conversion operators To: gdb-patches@sourceware.org References: <1508278336-8655-1-git-send-email-keiths@redhat.com> <9b6b1fae-ea57-f5ac-da59-59c7a94b236c@redhat.com> From: Keith Seitz Message-ID: Date: Wed, 18 Oct 2017 18:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <9b6b1fae-ea57-f5ac-da59-59c7a94b236c@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00572.txt.bz2 Content-length: 1246 On 10/18/2017 04:19 AM, Pedro Alves wrote: >> @@ -1630,7 +1630,13 @@ oper: OPERATOR NEW >> >> c_print_type ($2, NULL, &buf, -1, 0, >> &type_print_raw_options); >> - $$ = operator_stoken (buf.c_str ()); >> + >> + /* This also needs canonicalization. */ >> + std::string canon >> + = " " + cp_canonicalize_string (buf.c_str ()); >> + if (canon.length () == 1) >> + canon = " " + buf.string (); >> + $$ = operator_stoken (canon.c_str ()); > > The length() == 1 check gave me pause. It's checking that > cp_canonicalize_string returned empty of course, but it > wasn't super clear on a quick skim. > > I think you could write it like this, making that part clearer, > and also saving a few string dups and copies: > > /* This also needs canonicalization. */ > std::string canon > = cp_canonicalize_string (buf.c_str ()); > if (canon.empty ()) > canon = std::move (buf.string ()); > $$ = operator_stoken ((" " + canon).c_str ()); > > Yes, indeed. ISTR having something similar to that at one point, but I don't know why I changed it. [Maybe that was during the C++03/C++11 shake out?] In any case, committed with that change. Thank you for the review. Keith