From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42733 invoked by alias); 5 Jul 2017 10:32:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42723 invoked by uid 89); 5 Jul 2017 10:32:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Mingw, H*RU:14.03.0266.001, H*r:14.03.0266.001, Hx-spam-relays-external:14.03.0266.001 X-HELO: smtprelay.synopsys.com Received: from smtprelay2.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jul 2017 10:32:06 +0000 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 737FA10C1635; Wed, 5 Jul 2017 03:32:05 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 612E5EAB; Wed, 5 Jul 2017 03:32:05 -0700 (PDT) Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id 51BF8EAA; Wed, 5 Jul 2017 03:32:05 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.266.1; Wed, 5 Jul 2017 03:32:05 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Wed, 5 Jul 2017 12:32:03 +0200 From: Anton Kolesov To: Pedro Alves , Yao Qi CC: "gdb-patches@sourceware.org" , Francois Bedard , Sergio Durigan Junior Subject: RE: [PATCH] Import setenv and unsetenv from gnulib Date: Wed, 05 Jul 2017 10:32:00 -0000 Message-ID: <39A54937CC95F24AA2F794E2D2B66B135876E65F@DE02WEMBXB.internal.synopsys.com> References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> In-Reply-To: x-dg-ref: =?utf-8?B?UEcxbGRHRStQR0YwSUc1dFBTSmliMlI1TG5SNGRDSWdjRDBpWXpwY2RYTmxj?= =?utf-8?B?bk5jWVd0dmJHVnpiM1l1YzNsdWIzQnplWE5jWVhCd1pHRjBZVnh5YjJGdGFX?= =?utf-8?B?NW5YREE1WkRnME9XSTJMVE15WkRNdE5HRTBNQzA0TldWbExUWmlPRFJpWVRJ?= =?utf-8?B?NVpUTTFZbHh0YzJkelhHMXpaeTB5WkdVek9EZzJNeTAyTVRaa0xURXhaVGN0?= =?utf-8?B?WVRneE1TMDBPRFV4WWpjM1pUbGhPVFZjWVcxbExYUmxjM1JjTW1SbE16ZzRO?= =?utf-8?B?alV0TmpFMlpDMHhNV1UzTFdFNE1URXRORGcxTVdJM04yVTVZVGsxWW05a2VT?= =?utf-8?B?NTBlSFFpSUhONlBTSTROellpSUhROUlqRXpNVFF6TnpJME16SXhOelExTmpJ?= =?utf-8?B?d015SWdhRDBpWTNndlRTdG5iamRNVGpaVmJuWjZWV3hXWjJKUGRUZG1Ra3BC?= =?utf-8?B?UFNJZ2FXUTlJaUlnWW13OUlqQWlJR0p2UFNJeElpQmphVDBpWTBGQlFVRkZV?= =?utf-8?B?a2hWTVZKVFVsVkdUa05uVlVGQlFsRktRVUZDVEhKRWRuZGxabGhUUVdacU4y?= =?utf-8?B?aFVhR1pJVUZaMUsxQjFSazlHT0dNNVZ6UlBRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVaEJRVUZCUTJ0RFFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVWQlFWRkJRa0ZCUVVGMUswMHpNM2RCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRktORUZCUVVKdFFVZHJRV0puUW1oQlJ6UkJXWGRDYkVGR09F?= =?utf-8?B?RmpRVUp6UVVkRlFXSm5RblZCUjJ0QlltZENia0ZHT0VGa2QwSm9RVWhSUVZw?= =?utf-8?B?UlFubEJSekJCV1ZGQ2VVRkhjMEZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUlVG?= =?utf-8?B?QlFVRkJRVUZCUVVGblFVRkJRVUZCYm1kQlFVRkhXVUZpZDBJeFFVYzBRVnBC?= =?utf-8?B?UW5sQlNHdEJXSGRDZDBGSFJVRmpaMEl3UVVjMFFWcFJRbmxCU0UxQldIZENi?= =?utf-8?B?a0ZIV1VGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFWRkJRVUZCUVVGQlFVRkRRVUZCUVVGQlEyVkJRVUZCV21kQ2Rr?= =?utf-8?B?RklWVUZpWjBKclFVaEpRV1ZSUW1aQlNFRkJXVkZDZVVGSVVVRmlaMEpzUVVo?= =?utf-8?B?SlFXTjNRbVpCU0UxQldWRkNkRUZJVFVGa1VVSjFRVWRqUVZoM1FtcEJSemhC?= =?utf-8?B?WW1kQ2JVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUpCUVVGQlFVRkJRVUZCU1VGQlFVRkJRVW8w?= =?utf-8?B?UVVGQlFtMUJSemhCWkZGQ2RVRkhVVUZqWjBJMVFVWTRRV05CUW1oQlNFbEJa?= =?utf-8?B?RUZDZFVGSFZVRmpaMEo2UVVZNFFXTjNRbWhCUnpCQlkzZENNVUZITkVGYWQw?= =?utf-8?B?Sm1RVWhKUVZwUlFucEJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGRlFVRkJRVUZCUVVGQlFX?= =?utf-8?B?ZEJRVUZCUVVGdVowRkJRVWRaUVdKM1FqRkJSelJCV2tGQ2VVRklhMEZZZDBK?= =?utf-8?B?M1FVZEZRV05uUWpCQlJ6UkJXbEZDZVVGSVRVRllkMEo2UVVjd1FXRlJRbXBC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJVVUZC?= =?utf-8?B?UVVGQlFVRkJRVU5CUVVGQlFVRkRaVUZCUVVGYVowSjJRVWhWUVdKblFtdEJT?= =?utf-8?B?RWxCWlZGQ1prRklRVUZaVVVKNVFVaFJRV0puUW14QlNFbEJZM2RDWmtGSVRV?= =?utf-8?B?RmtRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUWtGQlFVRkJRVUZCUVVGSlFVRkJRVUZCU2pSQlFVRkNiVUZIT0VG?= =?utf-8?B?a1VVSjFRVWRSUVdOblFqVkJSamhCWTBGQ2FFRklTVUZrUVVKMVFVZFZRV05u?= =?utf-8?B?UW5wQlJqaEJaRUZDZWtGSE1FRlpkMEZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVVkJRVUZCUVVGQlFVRkJaMEZCUVVGQlFXNW5R?= =?utf-8?B?VUZCUjFsQlluZENNVUZITkVGYVFVSjVRVWhyUVZoM1FuZEJSMFZCWTJkQ01F?= =?utf-8?B?RkhORUZhVVVKNVFVaE5RVmgzUWpGQlJ6QkJXWGRCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZSUVVGQlFVRkJRVUZCUTBG?= =?utf-8?B?QlFVRkJRVU5sUVVGQlFWcDNRakJCU0UxQldIZENkMEZJU1VGaWQwSnJRVWhW?= =?utf-8?B?UVZsM1FqQkJSamhCWkVGQ2VVRkhSVUZoVVVKMVFVZHJRV0puUW01QlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQ1FVRkJR?= =?utf-8?B?VUZCUVVGQlFVbEJRVUZCUVVGS05FRkJRVUo2UVVkRlFXSkJRbXhCU0UxQldI?= =?utf-8?B?ZENhRUZIVFVGWmQwSjJRVWhWUVdKblFqQkJSamhCWTBGQ2MwRkhSVUZpWjBG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJSVUZCUVVGQlFVRkJRVUZuUVVGQlFVRkJibWRCUVVGSVRVRlpVVUp6?= =?utf-8?B?UVVkVlFXTjNRbVpCU0VWQlpGRkNka0ZJVVVGYVVVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVZGQlFVRkJRVUZCUVVGRFFVRkJRVUZCUTJWQlFV?= =?utf-8?B?RkJZM2RDZFVGSVFVRmpkMEptUVVkM1FXRlJRbXBCUjFWQlltZENla0ZIVlVG?= =?utf-8?B?WWQwSm9RVWhWUVdSQlFtOUJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVSkJRVUZCUVVGQlFVRkJTVUZC?= =?utf-8?B?UVVGQlFVbzBRVUZCUW5wQlJ6UkJZMEZDZWtGR09FRmlRVUp3UVVkTlFWcFJR?= =?utf-8?B?blZCU0UxQldsRkNaa0ZJVFVGa1FVSm9RVWhKUVdSQlFtWkJSMUZCV1ZGQ01F?= =?utf-8?B?RkhWVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZGUVVGQlFV?= =?utf-8?B?RkJRVUZCUVdkQlFVRkJRVUZ1WjBGQlFVaE5RV0puUW5kQlNFMUJXSGRDYzBG?= =?utf-8?B?SGEwRlpkMEpzUVVjMFFXTjNRbXhCUmpoQlpFRkNiRUZJU1VGaVVVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?Q?QUFBUUFBQUFBQUFBQUNBQUFBQUFBPSIvPjwvbWV0YT4=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2017-07/txt/msg00029.txt.bz2 PiANCj4gT24gMDcvMDQvMjAxNyAwNzowNiBQTSwgQW50b24gS29sZXNvdiB3 cm90ZToNCj4gPiBTZWxmdGVzdHMgcGFzcyBvbiB4ODZfNjQtbGludXguIE9u IFdpbmRvd3Mgd2l0aCB0aGlzIHBhdGNoIHRoZXJlIGlzIGENCj4gPiBmYWls dXJlIGluIGljb252IHNlZmx0ZXN0LCB3aGljaCBzZWVtcyB1bnJlbGF0ZWQg KHdhcyBwcmVzZW50IGV2ZW4NCj4gPiB3aGVuIEkndmUgdHJpZWQgdG8gdXNl IHB1dGVudiBkaXJlY3RseSBpbnN0ZWFkIG9mIGltcG9ydGluZyBnbnVsaWIg bW9kdWxlKS4NCj4gDQo+IEkgdGFrZSBpdCB5b3UgbWVhbnQgdGhlIHMvaWNv bnYvZ2RiX2Vudmlyb24vIHNlbGZ0ZXN0Lg0KPiBDYW4geW91IHNob3cgd2hh dCBkb2VzICJtYWludCBzZWxmdGVzdCIgc2F5Pw0KDQp6Olx0bXA+Z2RiLmV4 ZSAtZXggIm10IHNlbGZ0ZXN0IiAtYmF0Y2gNClNlbGYgdGVzdCBmYWlsZWQ6 IENvbnZlcnRpbmcgY2hhcmFjdGVyIHNldHM6IE5vIGVycm9yLg0KUmFuIDEx IHVuaXQgdGVzdHMsIDEgZmFpbGVkDQoNCkdyZXBwaW5nIGZvciAiQ29udmVy dGluZyBjaGFyYWN0ZXIgc2V0cyIgcG9pbnRzIHRvIGljb252X3dyYXBwZXIg aW4gY2hhcnNldC5jLg0KDQpJJ20gY3Jvc3MtYnVpbGRpbmcgd2l0aCBNaW5n dyBHQ0MgNC45LjIgZnJvbSBFUEVMIHJlcG9zaXRvcmllcyBmb3IgQ2VudE9T L1JIRUwgNi4NCk1heWJlIHNvbWUgcHJvYmxlbXMgd2l0aCB0aGlzIHRvb2xj aGFpbiBvciBteSB3aW5kb3dzIGVudmlyb25tZW50Lg0KDQpBbnRvbg0KDQo+ IA0KPiBUaGFua3MsDQo+IFBlZHJvIEFsdmVzDQoNCg== >From gdb-patches-return-140238-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Jul 05 12:25:42 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 47241 invoked by alias); 5 Jul 2017 12:25:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47206 invoked by uid 89); 5 Jul 2017 12:25:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Mingw X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jul 2017 12:25:40 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D9807F3ED; Wed, 5 Jul 2017 12:25:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9D9807F3ED Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9D9807F3ED Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31EF25C662; Wed, 5 Jul 2017 12:25:24 +0000 (UTC) Subject: Re: [PATCH] Import setenv and unsetenv from gnulib To: Anton Kolesov , Yao Qi References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876E65F@DE02WEMBXB.internal.synopsys.com> Cc: "gdb-patches@sourceware.org" , Francois Bedard , Sergio Durigan Junior From: Pedro Alves Message-ID: <0183eee2-dfb6-7b92-e7d2-b0fc2ea5cdb1@redhat.com> Date: Wed, 05 Jul 2017 12:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B135876E65F@DE02WEMBXB.internal.synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00030.txt.bz2 Content-length: 2209 On 07/05/2017 11:32 AM, Anton Kolesov wrote: >> >> On 07/04/2017 07:06 PM, Anton Kolesov wrote: >>> Selftests pass on x86_64-linux. On Windows with this patch there is a >>> failure in iconv sefltest, which seems unrelated (was present even >>> when I've tried to use putenv directly instead of importing gnulib module). >> >> I take it you meant the s/iconv/gdb_environ/ selftest. >> Can you show what does "maint selftest" say? > > z:\tmp>gdb.exe -ex "mt selftest" -batch > Self test failed: Converting character sets: No error. > Ran 11 unit tests, 1 failed > > Grepping for "Converting character sets" points to iconv_wrapper in charset.c. I put a breakpoint on iconv_wrapper::iconv_wrapper, and ran "mt selftest" on my GNU/Linux machine, and that leads to the Rust unit tests, from here in rust-exp.y: convert_between_encodings ("UTF-32", "UTF-8", (gdb_byte *) &value, sizeof (value), sizeof (value), &work_obstack, translit_none); That's "UTF-32" -> "UTF-8". I guess your build is using the phony iconv, which has (gdb/charset.c): /* We allow conversions from UTF-32, wchar_t, and the host charset. We allow conversions to wchar_t and the host charset. Return 1 if we are converting from UTF-32BE, 2 if from UTF32-LE, 0 otherwise. This is used as a flag in calls to iconv. */ static iconv_t phony_iconv_open (const char *to, const char *from) { if (strcmp (to, "wchar_t") && strcmp (to, GDB_DEFAULT_HOST_CHARSET)) return -1; if (!strcmp (from, "UTF-32BE") || !strcmp (from, "UTF-32")) return 1; if (!strcmp (from, "UTF-32LE")) return 2; if (strcmp (from, "wchar_t") && strcmp (from, GDB_DEFAULT_HOST_CHARSET)) return -1; return 0; } With host charset defined as: #undef GDB_DEFAULT_HOST_CHARSET #ifdef USE_WIN32API # define GDB_DEFAULT_HOST_CHARSET "CP1252" ... #endif > I'm cross-building with Mingw GCC 4.9.2 from EPEL repositories for CentOS/RHEL 6. > Maybe some problems with this toolchain or my windows environment. > So it looks like for proper Rust support on Windows, we'd either need to teach the phony iconv about utf-32 -> utf-8 conversion, or you have to link GDB with the real iconv. Thanks, Pedro Alves