From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53472 invoked by alias); 4 Jul 2017 18:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53429 invoked by uid 89); 4 Jul 2017 18:06:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*RU:14.03.0266.001, H*r:14.03.0266.001, Hx-spam-relays-external:14.03.0266.001, H*r:8321 X-HELO: smtprelay.synopsys.com Received: from smtprelay.synopsys.com (HELO smtprelay.synopsys.com) (198.182.60.111) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jul 2017 18:06:41 +0000 Received: from mailhost.synopsys.com (mailhost3.synopsys.com [10.12.238.238]) by smtprelay.synopsys.com (Postfix) with ESMTP id 08A4210C1541; Tue, 4 Jul 2017 11:06:40 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id E0E1D5D2; Tue, 4 Jul 2017 11:06:39 -0700 (PDT) Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2-vip.internal.synopsys.com [10.12.239.238]) by mailhost.synopsys.com (Postfix) with ESMTP id C0C6E5C3; Tue, 4 Jul 2017 11:06:39 -0700 (PDT) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WEHTC2.internal.synopsys.com (10.12.239.237) with Microsoft SMTP Server (TLS) id 14.3.266.1; Tue, 4 Jul 2017 11:06:31 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCB.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Tue, 4 Jul 2017 20:06:29 +0200 From: Anton Kolesov To: Yao Qi CC: "gdb-patches@sourceware.org" , Francois Bedard , Sergio Durigan Junior Subject: RE: [PATCH] Import setenv and unsetenv from gnulib Date: Tue, 04 Jul 2017 18:06:00 -0000 Message-ID: <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> In-Reply-To: x-dg-ref: =?utf-8?B?UEcxbGRHRStQR0YwSUc1dFBTSmliMlI1TG5SNGRDSWdjRDBpWXpwY2RYTmxj?= =?utf-8?B?bk5jWVd0dmJHVnpiM1l1YzNsdWIzQnplWE5jWVhCd1pHRjBZVnh5YjJGdGFX?= =?utf-8?B?NW5YREE1WkRnME9XSTJMVE15WkRNdE5HRTBNQzA0TldWbExUWmlPRFJpWVRJ?= =?utf-8?B?NVpUTTFZbHh0YzJkelhHMXpaeTAzWldRMFlqRXpNeTAyTUdVekxURXhaVGN0?= =?utf-8?B?WVRneE1TMDBPRFV4WWpjM1pUbGhPVFZjWVcxbExYUmxjM1JjTjJWa05HSXhN?= =?utf-8?B?elV0TmpCbE15MHhNV1UzTFdFNE1URXRORGcxTVdJM04yVTVZVGsxWW05a2VT?= =?utf-8?B?NTBlSFFpSUhONlBTSXhNVEl4SWlCMFBTSXhNekUwTXpZMk5URTROams1TXpF?= =?utf-8?B?eU5UWWlJR2c5SWpSNGVqaFBUaTluYTFGVU5sZDFhMlZIZW5kMlQwODFXRTlO?= =?utf-8?B?VFQwaUlHbGtQU0lpSUdKc1BTSXdJaUJpYnowaU1TSWdZMms5SW1OQlFVRkJS?= =?utf-8?B?VkpJVlRGU1UxSlZSazVEWjFWQlFVSlJTa0ZCUkRSb2FYaENPRkJVVTBGWFVr?= =?utf-8?B?Wk1SMnBVY1ZOSVUxcEZWWE5oVGs5d1NXUkpUMEZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRklRVUZCUVVOclEwRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGRlFVRlJRVUpCUVVGQmRTdE5Nek4zUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJTalJCUVVGQ2JVRkhhMEZpWjBKb1FVYzBRVmwzUW14QlJq?= =?utf-8?B?aEJZMEZDYzBGSFJVRmlaMEoxUVVkclFXSm5RbTVCUmpoQlpIZENhRUZJVVVG?= =?utf-8?B?YVVVSjVRVWN3UVZsUlFubEJSM05CUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVW?= =?utf-8?B?QlFVRkJRVUZCUVVGQlowRkJRVUZCUVc1blFVRkJSMWxCWW5kQ01VRkhORUZh?= =?utf-8?B?UVVKNVFVaHJRVmgzUW5kQlIwVkJZMmRDTUVGSE5FRmFVVUo1UVVoTlFWaDNR?= =?utf-8?B?bTVCUjFsQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRlJRVUZCUVVGQlFVRkJRMEZCUVVGQlFVTmxRVUZCUVZwblFu?= =?utf-8?B?WkJTRlZCWW1kQ2EwRklTVUZsVVVKbVFVaEJRVmxSUW5sQlNGRkJZbWRDYkVG?= =?utf-8?B?SVNVRmpkMEptUVVoTlFWbFJRblJCU0UxQlpGRkNkVUZIWTBGWWQwSnFRVWM0?= =?utf-8?B?UVdKblFtMUJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZDUVVGQlFVRkJRVUZCUVVsQlFVRkJRVUZL?= =?utf-8?B?TkVGQlFVSnRRVWM0UVdSUlFuVkJSMUZCWTJkQ05VRkdPRUZqUVVKb1FVaEpR?= =?utf-8?B?V1JCUW5WQlIxVkJZMmRDZWtGR09FRmpkMEpvUVVjd1FXTjNRakZCUnpSQldu?= =?utf-8?B?ZENaa0ZJU1VGYVVVSjZRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlJVRkJRVUZCUVVGQlFV?= =?utf-8?B?Rm5RVUZCUVVGQmJtZEJRVUZIV1VGaWQwSXhRVWMwUVZwQlFubEJTR3RCV0hk?= =?utf-8?B?Q2QwRkhSVUZqWjBJd1FVYzBRVnBSUW5sQlNFMUJXSGRDZWtGSE1FRmhVVUpx?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVkZC?= =?utf-8?B?UVVGQlFVRkJRVUZEUVVGQlFVRkJRMlZCUVVGQldtZENka0ZJVlVGaVowSnJR?= =?utf-8?B?VWhKUVdWUlFtWkJTRUZCV1ZGQ2VVRklVVUZpWjBKc1FVaEpRV04zUW1aQlNF?= =?utf-8?B?MUJaRUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVKQlFVRkJRVUZCUVVGQlNVRkJRVUZCUVVvMFFVRkJRbTFCUnpo?= =?utf-8?B?QlpGRkNkVUZIVVVGalowSTFRVVk0UVdOQlFtaEJTRWxCWkVGQ2RVRkhWVUZq?= =?utf-8?B?WjBKNlFVWTRRV1JCUW5wQlJ6QkJXWGRCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkZRVUZCUVVGQlFVRkJRV2RCUVVGQlFVRnVa?= =?utf-8?B?MEZCUVVkWlFXSjNRakZCUnpSQldrRkNlVUZJYTBGWWQwSjNRVWRGUVdOblFq?= =?utf-8?B?QkJSelJCV2xGQ2VVRklUVUZZZDBJeFFVY3dRVmwzUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCVVVGQlFVRkJRVUZCUVVO?= =?utf-8?B?QlFVRkJRVUZEWlVGQlFVRmFkMEl3UVVoTlFWaDNRbmRCU0VsQlluZENhMEZJ?= =?utf-8?B?VlVGWmQwSXdRVVk0UVdSQlFubEJSMFZCWVZGQ2RVRkhhMEZpWjBKdVFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFrRkJR?= =?utf-8?B?VUZCUVVGQlFVRkpRVUZCUVVGQlNqUkJRVUZDZWtGSFJVRmlRVUpzUVVoTlFW?= =?utf-8?B?aDNRbWhCUjAxQldYZENka0ZJVlVGaVowSXdRVVk0UVdOQlFuTkJSMFZCWW1k?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVVZCUVVGQlFVRkJRVUZCWjBGQlFVRkJRVzVuUVVGQlNFMUJXVkZD?= =?utf-8?B?YzBGSFZVRmpkMEptUVVoRlFXUlJRblpCU0ZGQldsRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGUlFVRkJRVUZCUVVGQlEwRkJRVUZCUVVObFFV?= =?utf-8?B?RkJRV04zUW5WQlNFRkJZM2RDWmtGSGQwRmhVVUpxUVVkVlFXSm5RbnBCUjFW?= =?utf-8?B?QldIZENhRUZJVlVGa1FVSnZRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkNRVUZCUVVGQlFVRkJRVWxC?= =?utf-8?B?UVVGQlFVRktORUZCUVVKNlFVYzBRV05CUW5wQlJqaEJZa0ZDY0VGSFRVRmFV?= =?utf-8?B?VUoxUVVoTlFWcFJRbVpCU0UxQlpFRkNhRUZJU1VGa1FVSm1RVWRSUVZsUlFq?= =?utf-8?B?QkJSMVZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUlVGQlFV?= =?utf-8?B?RkJRVUZCUVVGblFVRkJRVUZCYm1kQlFVRklUVUZpWjBKM1FVaE5RVmgzUW5O?= =?utf-8?B?QlIydEJXWGRDYkVGSE5FRmpkMEpzUVVZNFFXUkJRbXhCU0VsQllsRkJRVUZC?= =?utf-8?B?UVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJR?= =?utf-8?B?VUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFV?= =?utf-8?B?RkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVG?= =?utf-8?B?QlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZCUVVGQlFVRkJRVUZC?= =?utf-8?Q?QUFBQVFBQUFBQUFBQUFDQUFBQUFBQT0iLz48L21ldGE+?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2017-07/txt/msg00020.txt.bz2 PiA+IFBhdGNoIFsxXSBicm9rZSBhIGJ1aWxkIG9uIE1pbkdXIGhvc3RzLCBi ZWNhdXNlIE1pbkdXIGRvZXNuJ3QgcHJvdmlkZQ0KPiA+IFBPU0lYIGZ1bmN0 aW9ucyBzZXRlbnYgKCkgYW5kIHVuc2V0ZW52ICgpLiAgVGhpcyBjYW4gYmUg Zml4ZWQgYnkgdXNpbmcNCj4gPiBpbXBsZW1lbnRhdGlvbnMgZnJvbSBnbnVs aWIuDQo+ID4NCj4gPiBbMV0gaHR0cHM6Ly9zb3VyY2V3YXJlLm9yZy9naXQv P3A9YmludXRpbHMtZ2RiLmdpdDthPWNvbW1pdDtoPTlhNmM3ZDljMA0KPiA+ DQo+IA0KPiBXZSBuZWVkIGNvbW1pdCBoYXNoIGFuZCBzdWJqZWN0IG9ubHks IGxpa2UNCj4gDQo+IDlhNmM3ZDljMCAoQysraWZ5IGdkYi9jb21tb24vZW52 aXJvbi5jKQ0KPiANCj4gRGlkIHlvdSBydW4gcmVncmVzc2lvbiB0ZXN0IG9u IHg4Ni1saW51eD8gIElmIHRoZXJlIGlzIG5vIHJlZ3Jlc3Npb24sIHBhdGNo ZXMgaXMNCj4gZ29vZCB0byBtZS4NCg0KSWYgSSBydW4gIm1ha2UgY2hlY2st Z2RiIiwgSSBkb24ndCBzZWUgYW55IG9idmlvdXMgbmV3IGVycm9ycyBmcm9t IHRoaXMgcGF0Y2guDQpVbmZvcnR1bmF0ZWx5IHJlc3VsdHMgYXJlIGEgbGl0 dGxlIGJpdCB2b2xhdGlsZSAtIHNvbWUgdGVzdHMgc3BvcmFkaWNhbGx5IGZh aWwgZXZlbg0KaWYgSSBydW4gdGhlbSB3aXRoIHNhbWUgR0RCIGJ1aWxkIGFu ZCBzb3VyY2VzLCBldmVuIHdpdGhvdXQgdGhpcyBwYXRjaCAtIEkndmUgcnVu DQp0ZXN0c3VpdGUgZml2ZSB0aW1lcyBhbmQgZ290IGZpdmUgc2ltaWxhciwg YnV0IGRpZmZlcmVudCByZXN1bHRzLg0KDQpTZWxmdGVzdHMgcGFzcyBvbiB4 ODZfNjQtbGludXguIE9uIFdpbmRvd3Mgd2l0aCB0aGlzIHBhdGNoIHRoZXJl IGlzIGEgZmFpbHVyZSBpbg0KaWNvbnYgc2VmbHRlc3QsIHdoaWNoIHNlZW1z IHVucmVsYXRlZCAod2FzIHByZXNlbnQgZXZlbiB3aGVuIEkndmUgdHJpZWQg dG8gdXNlDQpwdXRlbnYgZGlyZWN0bHkgaW5zdGVhZCBvZiBpbXBvcnRpbmcg Z251bGliIG1vZHVsZSkuIA0KDQpBbnRvbg0KDQo+IA0KPiAtLQ0KPiBZYW8g KOm9kOWwpykNCg== >From gdb-patches-return-140229-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Jul 04 20:26:55 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 29720 invoked by alias); 4 Jul 2017 20:26:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29666 invoked by uid 89); 4 Jul 2017 20:26:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jul 2017 20:26:52 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E57B94E4CA; Tue, 4 Jul 2017 20:26:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E57B94E4CA Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E57B94E4CA Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE5697053C; Tue, 4 Jul 2017 20:26:50 +0000 (UTC) From: Sergio Durigan Junior To: Anton Kolesov Cc: Yao Qi , "gdb-patches\@sourceware.org" , Francois Bedard Subject: Re: [PATCH] Import setenv and unsetenv from gnulib References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> Date: Tue, 04 Jul 2017 20:26:00 -0000 In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> (Anton Kolesov's message of "Tue, 4 Jul 2017 18:06:28 +0000") Message-ID: <8737ac6j91.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00021.txt.bz2 Content-length: 1081 On Tuesday, July 04 2017, Anton Kolesov wrote: >> > Patch [1] broke a build on MinGW hosts, because MinGW doesn't provide >> > POSIX functions setenv () and unsetenv (). This can be fixed by using >> > implementations from gnulib. >> > >> > [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9a6c7d9c0 >> > >> >> We need commit hash and subject only, like >> >> 9a6c7d9c0 (C++ify gdb/common/environ.c) >> >> Did you run regression test on x86-linux? If there is no regression, patches is >> good to me. > > If I run "make check-gdb", I don't see any obvious new errors from this patch. > Unfortunately results are a little bit volatile - some tests sporadically fail even > if I run them with same GDB build and sources, even without this patch - I've run > testsuite five times and got five similar, but different results. Yeah, our testsuite has racy fails which are well known. What are the tests that fail sporadically? -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/