From: Anton Kolesov <Anton.Kolesov@synopsys.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Francois Bedard <Francois.Bedard@synopsys.com>
Subject: RE: [PATCH v3] arc: Select CPU model properly before disassembling
Date: Fri, 16 Jun 2017 12:03:00 -0000 [thread overview]
Message-ID: <39A54937CC95F24AA2F794E2D2B66B135875A495@DE02WEMBXB.internal.synopsys.com> (raw)
In-Reply-To: <c990680dda1f63f9f393755e0d642c1f@polymtl.ca>
> > + header). */
> > + if (info.target_desc != NULL)
> > + {
> > + const struct bfd_arch_info *tdesc_arch
> > + = tdesc_architecture (info.target_desc);
> > + if (tdesc_arch != NULL)
> > + {
> > + free (arc_disassembler_options);
>
> Nit: Use xfree instead of free.
>
> You can fix that and push directly.
Pushed, thanks for the review!
Anton
>
> Thanks!
>
> Simon
next prev parent reply other threads:[~2017-06-16 12:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 16:02 [PATCH] " Anton Kolesov
2017-06-05 20:07 ` Simon Marchi
2017-06-06 13:51 ` Anton Kolesov
2017-06-13 13:49 ` [PATCH v2] " Anton Kolesov
2017-06-13 22:16 ` Simon Marchi
[not found] ` <39A54937CC95F24AA2F794E2D2B66B1358756E48@DE02WEMBXB.internal.synopsys.com>
2017-06-14 16:27 ` Simon Marchi
2017-06-14 16:37 ` Pedro Alves
2017-06-15 13:20 ` Anton Kolesov
2017-06-15 13:20 ` [PATCH v3] " Anton Kolesov
2017-06-15 21:12 ` Simon Marchi
2017-06-16 12:03 ` Anton Kolesov [this message]
2017-06-13 21:31 ` [PATCH] " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39A54937CC95F24AA2F794E2D2B66B135875A495@DE02WEMBXB.internal.synopsys.com \
--to=anton.kolesov@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox