From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53798 invoked by alias); 6 Oct 2016 13:44:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53778 invoked by uid 89); 6 Oct 2016 13:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:2061 X-HELO: smtprelay.synopsys.com Received: from us01smtprelay-2.synopsys.com (HELO smtprelay.synopsys.com) (198.182.47.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 13:44:16 +0000 Received: from us02secmta1.synopsys.com (us02secmta1.synopsys.com [10.12.235.96]) by smtprelay.synopsys.com (Postfix) with ESMTP id 1D38824E2031; Thu, 6 Oct 2016 06:44:15 -0700 (PDT) Received: from us02secmta1.internal.synopsys.com (us02secmta1.internal.synopsys.com [127.0.0.1]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id 10CE54E215; Thu, 6 Oct 2016 06:44:15 -0700 (PDT) Received: from mailhost.synopsys.com (unknown [10.13.184.66]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id C76E64E214; Thu, 6 Oct 2016 06:44:14 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id B862F8AD; Thu, 6 Oct 2016 06:44:14 -0700 (PDT) Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id 959568AB; Thu, 6 Oct 2016 06:44:14 -0700 (PDT) Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.266.1; Thu, 6 Oct 2016 06:44:14 -0700 Received: from DE02WEMBXB.internal.synopsys.com ([fe80::95ce:118a:8321:a099]) by DE02WEHTCA.internal.synopsys.com ([::1]) with mapi id 14.03.0266.001; Thu, 6 Oct 2016 15:44:12 +0200 From: Anton Kolesov To: Pedro Alves , Doug Evans CC: gdb-patches , Wei-cheng Wang Subject: RE: [PATCH 4/5]: Enhancements to "flags": i386 cleanup Date: Thu, 06 Oct 2016 13:44:00 -0000 Message-ID: <39A54937CC95F24AA2F794E2D2B66B13581BF837@DE02WEMBXB.internal.synopsys.com> References: <047d7b5dbb865204bd052cf0bc2b@google.com> <2026a39c-0b53-9142-74ce-091bc73832d8@redhat.com> <7635a6d6-4059-6b23-952c-a88dbfef3b18@redhat.com> <187cd5cc-be8d-3a61-66cd-338ea68a72f8@redhat.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2016-10/txt/msg00119.txt.bz2 SGkgUGVkcm8sDQoNCj4gDQo+IE5vdGUgaG93IHRoYXQgbGVmdCBzZXZlcmFs IGZsYWdzIHdpdGggMi1iaXQgYW5kL29yIDQtYml0DQo+IGxvbmcgYml0Zmll bGRzOg0KPiANCj4gICAgdGRlc2NfYWRkX2JpdGZpZWxkICh0eXBlLCAiRSIs IDEsIDIpOw0KPiAgICB0ZGVzY19hZGRfYml0ZmllbGQgKHR5cGUsICJBIiwg MywgNCk7DQo+IC4uLg0KPiAgICB0ZGVzY19hZGRfYml0ZmllbGQgKHR5cGUs ICJFIiwgMSwgNCk7DQo+IA0KPiB3aGljaCBJIHVuZGVyc3RhbmQgbWVhbnMg dGhlc2UgdHdvIGZpZWxkcyB3aWxsDQo+IGJlIGdpdmVuIHVpbnQzMl90IHR5 cGUgaW5zdGVhZCBvZiBib29sPyAgV2hhdCBkb2VzIHRoaXMNCj4gbWVhbiBp biBwcmFjdGljZT8gIEUuZywuIGZvciAiQSIsIHdoYXQgZG8gd2UgcHJpbnQg d2hlbiBib3RoDQo+IGJpdHMgMyBhbmQgNCBhcmUgY2xlYXI/ICBXaGF0IGRv IHdlIHByaW50IGlmIG9uZQ0KPiBvZiB0aGUgYml0cyBpcyBzZXQgYW5kIHRo ZSBvdGhlciBpcyBjbGVhcj8NCg0KV2l0aCByZWdhcmRzIG9mIEFSQyBmbGFn cywgaWYgZmllbGQgaXMgbG9uZ2VyIHRoYW4gb25lIGJpdCwgdGhlbiBpdCBz aG91bGQgYmUNCnRyZWF0ZWQgYXMgYW4gdWludC4gRm9yIGV4YW1wbGUsIGlu IGFyYy12Mi5jIGZpZWxkIEggbWVhbnMgImhhbHQgYml0Iiwgc28NCml0IGlz IGEgc2luZ2xlIGJpdCwgYnV0IEUgaXMgYSAiSW50ZXJydXB0IHByaW9yaXR5 IGxldmVsIiwgc28gYml0cyBhcmUgbm90DQppbmRlcGVuZGVudCBpbiB0aGlz IGZpZWxkIC0gaXQgaXMgYSA0LWJpdCBpbnRlZ2VyIG51bWJlciwgdGhlcmUg aXMgbm8gaWRlYQ0Kb2YgaW5kZXBlbmRlbnQgImZpcnN0IGJpdCIgb3IgInNl Y29uZCBiaXQiIGluc2lkZSB0aGlzIGZpZWxkLiBJZiB0aGVyZSB3b3VsZCwN CnRoZW4gSSdkIHNwbGl0IGl0IGludG8gc2VwYXJhdGUgZmllbGRzIGJpdHMu IFNvIGl0IHNob3VsZCBiZSBwcmludGVkIHNvbWV0aGluZw0KbGlrZSAiWyBI IEU9MSBBRSBdIiAtIGJpdHMgcHJpbnRlZCBvbmx5IHdoZW4gdGhleSBhcmUg c2V0LCB1aW50IGZpZWxkcyBhcmUNCnByaW50ZWQgYXMgIm5hbWU9dmFsdWUi LCB0aG91Z2ggSSdtIG5vdCBzdXJlIGlmIGl0IHNob3VsZCBiZSBwcmludGVk IGlmIHZhbHVlDQppcyAwLiBBdCBsZWFzdCB0aGF0IGlzIHdoYXQgYXJlIG15 IGV4cGVjdGF0aW9ucyBvZiBob3cgImZsYWdzIiByZWdpc3RlciBzaG91bGQN CmJlIHByZXNlbnRlZC4NCg0KQW50b24NCg0KPiANCj4gSSBzZWUgc2ltaWxh ciB0aGluZ3Mgb24gb3RoZXIgYXJjaHMgdGhvdWdoLCBpdCdzDQo+IG5vdCBq dXN0IEFSQy4gIEUuZy4sIHRoZSBwYXRjaCByZXN1bHRlZCBpbjoNCj4gDQo+ IC0tLSBhL2dkYi9mZWF0dXJlcy9hYXJjaDY0LmMNCj4gKysrIGIvZ2RiL2Zl YXR1cmVzL2FhcmNoNjQuYw0KPiBAQCAtMTksMTAgKzE5LDEwIEBAIGluaXRp YWxpemVfdGRlc2NfYWFyY2g2NCAodm9pZCkNCj4gICAgZmVhdHVyZSA9IHRk ZXNjX2NyZWF0ZV9mZWF0dXJlIChyZXN1bHQsICJvcmcuZ251LmdkYi5hYXJj aDY0LmNvcmUiKTsNCj4gICAgdHlwZSA9IHRkZXNjX2NyZWF0ZV9mbGFncyAo ZmVhdHVyZSwgImNwc3JfZmxhZ3MiLCA0KTsNCj4gICAgdGRlc2NfYWRkX2Zs YWcgKHR5cGUsIDAsICJTUCIpOw0KPiAtICB0ZGVzY19hZGRfYml0ZmllbGQg KHR5cGUsICIiLCAxLCAxKTsNCj4gKyAgdGRlc2NfYWRkX2ZsYWcgKHR5cGUs IDEsICIiKTsNCj4gICAgdGRlc2NfYWRkX2JpdGZpZWxkICh0eXBlLCAiRUwi LCAyLCAzKTsNCj4gICAgdGRlc2NfYWRkX2ZsYWcgKHR5cGUsIDQsICJuUlci KTsNCj4gLSAgdGRlc2NfYWRkX2JpdGZpZWxkICh0eXBlLCAiIiwgNSwgNSk7 DQo+ICsgIHRkZXNjX2FkZF9mbGFnICh0eXBlLCA1LCAiIik7DQo+ICAgIHRk ZXNjX2FkZF9mbGFnICh0eXBlLCA2LCAiRiIpOw0KPiAgICB0ZGVzY19hZGRf ZmxhZyAodHlwZSwgNywgIkkiKTsNCj4gICAgdGRlc2NfYWRkX2ZsYWcgKHR5 cGUsIDgsICJBIik7DQo+IA0KPiBXaGljaCBsZWF2ZXMgIkVMIiBhcyBhIDIt Yml0IGJpdGZpZWxkLg0KPiANCj4gSSdtIHN0aWxsIHRlcnJpYmx5IGNvbmZ1 c2VkLiAgOi0vDQo+IA0KPiBUaGFua3MsDQo+IFBlZHJvIEFsdmVzDQoNCg== >From gdb-patches-return-133709-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Oct 06 13:58:40 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 45156 invoked by alias); 6 Oct 2016 13:58:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 45145 invoked by uid 89); 6 Oct 2016 13:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=trick, gdbpatchesownersourcewareorg, H*RU:14.3.248.2, gdb-patches-owner@sourceware.org X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 13:58:29 +0000 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP; 06 Oct 2016 06:58:27 -0700 X-ExtLoop1: 1 Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga004.jf.intel.com with ESMTP; 06 Oct 2016 06:58:26 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 6 Oct 2016 14:58:25 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.19]) by irsmsx112.ger.corp.intel.com ([169.254.1.170]) with mapi id 14.03.0248.002; Thu, 6 Oct 2016 14:58:25 +0100 From: "Metzger, Markus T" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb.btrace/*.exp: Make test names unique Date: Thu, 06 Oct 2016 13:58:00 -0000 Message-ID: References: <20161003191729.1412-1-simon.marchi@ericsson.com> In-Reply-To: <20161003191729.1412-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00120.txt.bz2 Content-length: 7096 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Simon Marchi > Sent: Monday, October 3, 2016 9:17 PM > To: gdb-patches@sourceware.org > Cc: Simon Marchi > Subject: [PATCH] gdb.btrace/*.exp: Make test names unique Hi Simon, Thanks for your patch. > This patch makes the btrace test names unique. I was trying to > understand why rn-dl-bind.exp fails on my machine, and saw that it > failed at test "next". Given that there are multiple "next" in that > test, it's hard to know which one doesn't work. >=20 > In most cases, I simply added a "#N" suffix to the test cases, since I > couldn't find a more appropriate name from the context. >=20 > For the record, I still don't know why rt-dl-bind.exp fails, but I don't > intend to spend more time on it (at least for now). On what system are you seeing those fails? > diff --git a/gdb/testsuite/gdb.btrace/delta.exp > b/gdb/testsuite/gdb.btrace/delta.exp > index c9dbf38..c822400 100644 > --- a/gdb/testsuite/gdb.btrace/delta.exp > +++ b/gdb/testsuite/gdb.btrace/delta.exp > @@ -47,7 +47,7 @@ with_test_prefix "no trace" { > } >=20 > # we record each single-step, even if we have not seen a branch, yet. > -gdb_test "stepi" > +gdb_test "stepi" "main\.4.*" "stepi #1" I wouldn't count on the stepi landing there. This is also not relevant for= the test. I'd rather add test prefixes for the below groups of tests and leave the in= itial "next" and "stepi" that move to the relevant code and record the trace as they are. I.e. here... > # check that we can reverse-stepi that instruction ... and here ... > # and back We also wouldn't need to count the "info record" commands in this case. > diff --git a/gdb/testsuite/gdb.btrace/enable.exp Instead of adding a counter here ... > # enable btrace > -gdb_test_no_output "record btrace" "record btrace" > +gdb_test_no_output "record btrace" "record btrace #1" ... we might want to add a test prefix here ... > @@ -90,7 +90,7 @@ clean_restart $testfile > if ![runto_main] { > return -1 > } > -gdb_test_no_output "record btrace" > +gdb_test_no_output "record btrace" "record btrace #2" > if ![runto_main] { > return -1 > } > diff --git a/gdb/testsuite/gdb.btrace/function_call_history.exp > b/gdb/testsuite/gdb.btrace/function_call_history.exp > index 7d1e4049..53fd239 100644 > --- a/gdb/testsuite/gdb.btrace/function_call_history.exp > +++ b/gdb/testsuite/gdb.btrace/function_call_history.exp > @@ -30,7 +30,7 @@ if ![runto_main] { > } >=20 > # start btrace > -gdb_test_no_output "record btrace" > +gdb_test_no_output "record btrace" "record btrace #1" >=20 > # set bp after increment loop and continue > set bp_location [gdb_get_line_number "bp.1" $testfile.c] > @@ -236,7 +236,7 @@ gdb_continue_to_breakpoint "cont to fib.3" > gdb_continue_to_breakpoint "cont to fib.4" >=20 > # start tracing > -gdb_test_no_output "record btrace" > +gdb_test_no_output "record btrace" "record btrace #2" The bottom of this file from the second "runto_main" is really an independent test. We might either prefix the entire test from the second runto_main until the end of the file or split the file into two. > diff --git a/gdb/testsuite/gdb.btrace/nohist.exp > -proc check_not_replaying {} { > +proc check_not_replaying { test } { > gdb_test "info record" [multi_line \ > "Active record target: record-btrace" \ > "Recording format: .*" \ > "Recorded 0 instructions in 0 functions \\\(0 gaps\\\) for \[^\\\r\\\n\= ]*" \ > - ] > + ] \ > + $test > } >=20 > gdb_test_no_output "record btrace" >=20 > -check_not_replaying > +check_not_replaying "check not replaying #1" I think a couple of test prefixes would be more helpful, here. > diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp > -with_test_prefix "navigate" { > +with_test_prefix "navigate #1" { > gdb_test "thread apply 1 record goto 2" "$loop_line" > gdb_test "thread apply 2 record goto 4" "$loop_line" > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 2\." > gdb_test "thread apply 2 info record" \ > ".*Replay in progress\. At instruction 4\." > +} >=20 > +with_test_prefix "navigate #2" { > gdb_test "thread apply all record goto 5" "$loop_line" > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 5\." > @@ -175,29 +181,37 @@ with_test_prefix "continue" { > with_test_prefix "thread 1" { > gdb_cont_to_no_history 1 "continue" 1 > gdb_test "thread apply 1 info record" \ > - ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" > + ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" \ > + "thread apply 1 info record #1" > gdb_test "thread apply 2 info record" \ > - ".*Replay in progress\. At instruction 5\." > + ".*Replay in progress\. At instruction 5\." \ > + "thread apply 2 info record #1" >=20 > gdb_cont_to_no_history 1 "reverse-continue" 1 > gdb_test "thread apply 1 info record" \ > - ".*Replay in progress\. At instruction 1\." > + ".*Replay in progress\. At instruction 1\." \ > + "thread apply 1 info record #2" > gdb_test "thread apply 2 info record" \ > - ".*Replay in progress\. At instruction 5\." > + ".*Replay in progress\. At instruction 5\." \ > + "thread apply 2 info record #2" > } Could we do the same trick you did with the "navigate" tests here, as well? I.e. split the "continue" tests into sub-groups with separate prefixes. > diff --git a/gdb/testsuite/gdb.btrace/stepi.exp > b/gdb/testsuite/gdb.btrace/stepi.exp > index b21e4e5..54cde46 100644 > --- a/gdb/testsuite/gdb.btrace/stepi.exp > +++ b/gdb/testsuite/gdb.btrace/stepi.exp > @@ -67,18 +67,18 @@ gdb_test_no_output "record btrace" > gdb_test "next" >=20 > # we start with stepping to make sure that the trace is fetched automati= cally > -gdb_test "reverse-stepi" ".*fun4\.5.*" > -gdb_test "reverse-stepi" ".*fun4\.5.*" > +gdb_test "reverse-stepi" ".*fun4\.5.*" "reverse-stepi #1" > +gdb_test "reverse-stepi" ".*fun4\.5.*" "reverse-stepi #2" >=20 > # let's check where we are in the trace > with_test_prefix "reverse-stepi to 39" { check_replay_at 39 } >=20 > # let's step forward and check again > -gdb_test "stepi" ".*fun4\.5.*" > +gdb_test "stepi" ".*fun4\.5.*" "stepi #1" > with_test_prefix "stepi to 40" { check_replay_at 40 } We could extend the test prefix to cover the stepping command in addition to the check. We'd still need to count in a few cases where we need two identical stepping commands. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928