Hi all, It seems that I should have removed call to [target_info exists] in this patch as well, as it is redundant, since if variable is not set, then an empty string will be returned. However if needs_status_wrapper was explicitly set to an empty string, then [target_info exists] will have a different result than comparison with an empty string. Dejagnu itself in remote.exp compares needs_status_wrapper with an empty string, so I think that the same should be done in GDB test suite. If there are no other objections I will send an updated patch. -- Anton Kolesov > -----Original Message----- > From: Anton Kolesov [mailto:Anton.Kolesov@synopsys.com] > Sent: 17 October 2013 16:59 > To: gdb-patches@sourceware.org > Cc: Anton Kolesov; Jeremy.bennett@embecosm.com > Subject: [PATCH] testsuite: Treat empty string in needs_status_wrapper as > a false value > > GCC testsuite treats empty string in [target_info needs_status_wrapper] > the > same way as "0" - as a false value. GDB testsuite on the other hand > recognizes > only zero as false. This patch changes this to improve compatibilty of > board files. > > gdb/testsuite/ChangeLog: > > 2013-10-17 Anton Kolesov > > * lib/gdb.exp (gdb_compile, gdb_wrapper_init): Treat empty string in > target_info needs_status_wrapper the same way as zero - as a false > value. > --- > gdb/testsuite/lib/gdb.exp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 3efd539..f5f1555 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -2511,6 +2511,7 @@ proc gdb_wrapper_init { args } { > if { $gdb_wrapper_initialized == 1 } { return; } > > if {[target_info exists needs_status_wrapper] && \ > + [target_info needs_status_wrapper] != "" && \ > [target_info needs_status_wrapper] != "0"} { > set result [build_wrapper "testglue.o"] > if { $result != "" } { > @@ -2610,6 +2611,7 @@ proc gdb_compile {source dest type options} { > if { $gdb_wrapper_initialized == 0 } { gdb_wrapper_init } > > if {[target_info exists needs_status_wrapper] && \ > + [target_info needs_status_wrapper] != "" && \ > [target_info needs_status_wrapper] != "0" && \ > [info exists gdb_wrapper_file]} { > lappend options "libs=${gdb_wrapper_file}" > -- > 1.8.4.1 &j!z޶Nәb֫rnr